fix(ui5-select): announce header text on mobile #11849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetyaMarkovaBogdanova
approved these changes
Jul 4, 2025
…een-reader-output
There was a problem hiding this comment.
Pull Request Overview
This PR fixes accessibility issues with the Select component on mobile devices by ensuring proper screen reader announcements. The fix ensures that when a Select popover opens on mobile, the header text is announced to assistive technologies by setting the accessibleName property on the ResponsivePopover.
- Adds
accessibleNameproperty to ResponsivePopover on mobile devices - Improves focus handling for selected options in the popover
- Adds comprehensive test coverage for both mobile and desktop scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/main/src/SelectPopoverTemplate.tsx | Sets accessibleName for ResponsivePopover only on mobile devices |
| packages/main/src/Select.ts | Enhances focus application to selected options by calling focus() method |
| packages/main/cypress/specs/Select.mobile.cy.tsx | Adds test to verify accessibleName is properly set on mobile |
| packages/main/cypress/specs/Select.cy.tsx | Adds tests for desktop accessibleName absence and focus behavior |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11495
Summary
Fixes mobile accessibility issues for the Select component.
Changes