-
Notifications
You must be signed in to change notification settings - Fork 278
feat(ui5-view-settings-dialog): add group option #11950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new Group option to the ui5-view-settings-dialog
component, allowing users to select grouping criteria for data organization similar to the existing Sort functionality.
Key changes:
- Added new
ui5-group-item
component for defining group options - Extended ViewSettingsDialog to support grouping alongside sorting and filtering
- Updated event details and settings to include group-related properties
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/fiori/src/GroupItem.ts | New component definition for group items with text and selected properties |
packages/fiori/src/ViewSettingsDialog.ts | Extended to support group functionality with new properties, methods, and event details |
packages/fiori/src/ViewSettingsDialogTemplate.tsx | Updated template to render group UI and consolidated sort/group rendering logic |
packages/fiori/src/types/ViewSettingsDialogMode.ts | Added Group mode enum value |
packages/fiori/src/i18n/messagebundle.properties | Added i18n keys for group-related labels and tooltips |
packages/fiori/test/pages/ViewSettingsDialog.html | Added test page example with group functionality |
packages/fiori/cypress/specs/ViewSettingsDialog.cy.tsx | Added comprehensive test coverage for group functionality |
packages/website/docs/_samples/fiori/ViewSettingsDialog/Basic/sample.html | Updated sample to demonstrate group items usage |
🎉 This PR is included in version v2.15.0-rc.0 🎉 The release is available on v2.15.0-rc.0 Your semantic-release bot 📦🚀 |
This feature introduces a new Group option to the
ui5-view-settings-dialog
allowing users to select a group of options and in what way they should be ordered, similar to the Sort option.To use the Group option, we introduced a
ui5-group-item
that can be slotted in thegroupItems
slot of aui5-view-settings-dialog
. The following example is how theui5-group-item
can be used:With that example, the view settings dialog will look something like this:
Fixes: #11815