Skip to content

Conversation

didip1000
Copy link
Contributor

@didip1000 didip1000 commented Jul 21, 2025

This feature introduces a new Group option to the ui5-view-settings-dialog allowing users to select a group of options and in what way they should be ordered, similar to the Sort option.

To use the Group option, we introduced a ui5-group-item that can be slotted in the groupItems slot of a ui5-view-settings-dialog. The following example is how the ui5-group-item can be used:

<ui5-view-settings-dialog id="vsd1" sort-descending>
    <ui5-group-item slot="groupItems" text="Name" selected=""></ui5-group-item>
    <ui5-group-item slot="groupItems" text="Position"></ui5-group-item>
    <ui5-group-item slot="groupItems" text="Company"></ui5-group-item>
    <ui5-group-item slot="groupItems" text="Department"></ui5-group-item>
    <ui5-group-item slot="groupItems" text="(Not Grouped)"></ui5-group-item>
</ui5-view-settings-dialog>

With that example, the view settings dialog will look something like this:

ViewSettingsDialog Group option

Fixes: #11815

@didip1000 didip1000 self-assigned this Jul 21, 2025
@didip1000 didip1000 marked this pull request as ready for review August 19, 2025 14:32
@ilhan007 ilhan007 requested a review from Copilot August 29, 2025 11:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Group option to the ui5-view-settings-dialog component, allowing users to select grouping criteria for data organization similar to the existing Sort functionality.

Key changes:

  • Added new ui5-group-item component for defining group options
  • Extended ViewSettingsDialog to support grouping alongside sorting and filtering
  • Updated event details and settings to include group-related properties

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/fiori/src/GroupItem.ts New component definition for group items with text and selected properties
packages/fiori/src/ViewSettingsDialog.ts Extended to support group functionality with new properties, methods, and event details
packages/fiori/src/ViewSettingsDialogTemplate.tsx Updated template to render group UI and consolidated sort/group rendering logic
packages/fiori/src/types/ViewSettingsDialogMode.ts Added Group mode enum value
packages/fiori/src/i18n/messagebundle.properties Added i18n keys for group-related labels and tooltips
packages/fiori/test/pages/ViewSettingsDialog.html Added test page example with group functionality
packages/fiori/cypress/specs/ViewSettingsDialog.cy.tsx Added comprehensive test coverage for group functionality
packages/website/docs/_samples/fiori/ViewSettingsDialog/Basic/sample.html Updated sample to demonstrate group items usage

@didip1000 didip1000 merged commit 77bd73e into main Sep 9, 2025
12 checks passed
@didip1000 didip1000 deleted the vsd-group-option branch September 9, 2025 09:51
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.15.0-rc.0 🎉

The release is available on v2.15.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]:ViewSettingsDialog should show group tabs
4 participants