Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 5, 2025

  • Fix SegmentedButton ARIA attributes for accessibility compliance
    • Add conditional aria-multiselectable based on selection mode
    • Add aria-orientation="horizontal" attribute
  • Add focused Cypress test for aria-multiselectable validation
    • Tests both Single mode (aria-multiselectable="false") and Multiple mode (aria-multiselectable="true")
    • Validates aria-orientation="horizontal" is present in both modes

Fixes: #12263

Copy link

cla-assistant bot commented Sep 5, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ilhan007
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

cla-assistant bot commented Sep 5, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI and others added 2 commits September 5, 2025 11:52
…e and add aria-orientation

Co-authored-by: ilhan007 <15702139+ilhan007@users.noreply.github.com>
Co-authored-by: ilhan007 <15702139+ilhan007@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] [SegmentedButton]: Incorrect and missing ARIA Attribute fix(ui5-segmented-button): correct ARIA attributes for accessibility compliance Sep 5, 2025
Copilot finished work on behalf of ilhan007 September 5, 2025 11:59
@Copilot Copilot AI requested a review from ilhan007 September 5, 2025 11:59
@ilhan007
Copy link
Contributor

ilhan007 commented Sep 5, 2025

Hi @copilot

Remove the html code and the test, just add one more test in the SegmentedButton.cy.tsx similar to the

it("segmented button item should have correct aria descriptions", () => {
...

maybe

it("segmented button item should have correct aria-multiselectable", () => {
...

@ilhan007 ilhan007 marked this pull request as ready for review September 10, 2025 06:24
@ilhan007
Copy link
Contributor

Hi @copilot

Remove the html code and the test, just add one more test in the SegmentedButton.cy.tsx similar to the

it("segmented button item should have correct aria descriptions", () => {
...

maybe

it("segmented button item should have correct aria-multiselectable", () => {
...

…a-multiselectable

Co-authored-by: ilhan007 <15702139+ilhan007@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Sep 10, 2025

Hi @copilot

...

Completed! Removed the HTML test code and unit test file, and added the requested Cypress test "segmented button should have correct aria-multiselectable" following the same pattern as the existing aria descriptions test. The test validates both selection modes and the horizontal orientation. See commit d610581.

Copy link
Contributor Author

Copilot AI commented Sep 10, 2025

Hi @copilot

Remove the html code and the test, just add one more test in the SegmentedButton.cy.tsx similar to the
...

Done! I've removed the HTML test code and unit test, and added a focused Cypress test "segmented button should have correct aria-multiselectable" in SegmentedButton.cy.tsx that validates both Single mode (aria-multiselectable="false") and Multiple mode (aria-multiselectable="true"), plus aria-orientation="horizontal" for both modes. Changes committed in d610581.

Copilot finished work on behalf of ilhan007 September 10, 2025 06:30
@ilhan007 ilhan007 merged commit 9864285 into main Sep 11, 2025
21 of 22 checks passed
@ilhan007 ilhan007 deleted the copilot/fix-12263 branch September 11, 2025 13:48
nnaydenow pushed a commit that referenced this pull request Sep 12, 2025
…ntation="horizontal" (#12270)

Fixes SegmentedButton ARIA attributes for accessibility compliance
- Add conditional aria-multiselectable based on selection mode
- Add aria-orientation="horizontal" attribute

Fixes: #12263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SegmentedButton]: Incorrect and missing ARIA Attribute
3 participants