-
Notifications
You must be signed in to change notification settings - Fork 278
fix(ui5-segmented-button): correct ARIA attributes for accessibility compliance #12270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
…e and add aria-orientation Co-authored-by: ilhan007 <15702139+ilhan007@users.noreply.github.com>
Co-authored-by: ilhan007 <15702139+ilhan007@users.noreply.github.com>
Hi @copilot Remove the html code and the test, just add one more test in the SegmentedButton.cy.tsx similar to the it("segmented button item should have correct aria descriptions", () => {
... maybe it("segmented button item should have correct aria-multiselectable", () => {
... |
Hi @copilot Remove the html code and the test, just add one more test in the SegmentedButton.cy.tsx similar to the it("segmented button item should have correct aria descriptions", () => {
... maybe it("segmented button item should have correct aria-multiselectable", () => {
... |
…a-multiselectable Co-authored-by: ilhan007 <15702139+ilhan007@users.noreply.github.com>
... Completed! Removed the HTML test code and unit test file, and added the requested Cypress test |
Done! I've removed the HTML test code and unit test, and added a focused Cypress test |
aria-multiselectable
based on selection modearia-orientation="horizontal"
attributearia-multiselectable="false"
) and Multiple mode (aria-multiselectable="true"
)aria-orientation="horizontal"
is present in both modesFixes: #12263