Skip to content

fix(ui5-dialog): fix RTL Dialog resizing to keep right edge anchored #12313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 24, 2025
Merged

fix(ui5-dialog): fix RTL Dialog resizing to keep right edge anchored #12313

merged 5 commits into from
Sep 24, 2025

Conversation

s-todorova
Copy link
Contributor

fixes: #12310

@s-todorova s-todorova requested a review from a team September 16, 2025 12:55
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Sep 16, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Stoev
Stoev reviewed Sep 17, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for the commit header: Maybe shift focus in commit header towards what is achieved. For example:

fix RTL Dialog resizing to keep right edge anchored

@s-todorova s-todorova changed the title fix(ui5-dialog): top-right corner no longer shifts when resizing in RTL fix(ui5-dialog): fix RTL Dialog resizing to keep right edge anchored Sep 17, 2025
@s-todorova s-todorova requested a review from a team September 18, 2025 06:34
@s-todorova s-todorova merged commit e50d0b8 into main Sep 24, 2025
10 checks passed
@s-todorova s-todorova deleted the rtl-dialog-shift branch September 24, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stoev Stoev Stoev left review comments

@TeodorTaushanov TeodorTaushanov TeodorTaushanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dialog]: Top-right corner shifts to the right when resizing in RTL mode
3 participants
@s-todorova @TeodorTaushanov @Stoev