Skip to content

fix(ui5-shellbar-item): correct getFocusDomRef return value #12328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

fix(ui5-shellbar-item): correct getFocusDomRef return value #12328

merged 1 commit into from
Sep 26, 2025

Conversation

dobrinyonkov
Copy link
Contributor

Improves ShellBarItem focus handling when moving between the ShellBar's main area and overflow popover.

Changes

  • Switched _getRealDomRef to use shadowRoot for accurate queries.
  • Applied data-ui5-stable only to visible items and overflow popover entries for reliable DOM targeting.
  • Added Cypress tests to verify getFocusDomRef() in both contexts.

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova requested review from NakataCode and plamenivanov91 and removed request for NakataCode September 25, 2025 07:39
@dobrinyonkov dobrinyonkov merged commit f292890 into main Sep 26, 2025
10 checks passed
@dobrinyonkov dobrinyonkov deleted the fix/shellbar-item-dom-ref branch September 26, 2025 11:21
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.15.0-rc.3 🎉

The release is available on v2.15.0-rc.3

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamenivanov91 plamenivanov91 plamenivanov91 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dobrinyonkov @ui5-webcomponents-bot @plamenivanov91