Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APIM-468): change how integer config values are parsed #357

Merged
merged 6 commits into from
Jul 28, 2023
Merged

feat(APIM-468): change how integer config values are parsed #357

merged 6 commits into from
Jul 28, 2023

Conversation

avaitonis
Copy link
Contributor

Introduction

Current way to parse environment variables and set default value doesn't allow using 0. 0 can be useful for APIM_INFORMATICA_MAX_REDIRECTS, APIM_INFORMATICA_TIMEOUT and similar integer environment variables.

Resolution

This is copy of similar implementation in TFS API.
Created helper getIntConfig. It parses input string and returns integer from input or optional default value.

Helper throws exception for these edge cases:

  • input is set, but not string
  • input and default values are undefined
  • input is not integer in string format. For example it is float or has some non digital characters
  • input number is not using decimal base

Misc

Moved boolean environment variable test to shared test withEnvironmentVariableParsingUnitTests

@avaitonis avaitonis temporarily deployed to qa July 26, 2023 10:57 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 26, 2023 10:57 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 26, 2023 10:58 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 26, 2023 11:02 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 26, 2023 11:02 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 26, 2023 11:02 — with GitHub Actions Inactive
IgnatG
IgnatG previously approved these changes Jul 26, 2023
View reviewed changes
@avaitonis avaitonis requested a review from IgnatG July 28, 2023 08:37
@avaitonis avaitonis temporarily deployed to qa July 28, 2023 08:52 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 28, 2023 08:52 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 28, 2023 08:52 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 28, 2023 09:36 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 28, 2023 09:36 — with GitHub Actions Inactive
@avaitonis avaitonis temporarily deployed to qa July 28, 2023 09:36 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@avaitonis avaitonis merged commit ee24d08 into main Jul 28, 2023
13 checks passed
@avaitonis avaitonis deleted the feat/apim-468/allow-numeric-environment-variables-to-be-set-to-0 branch July 28, 2023 10:27
@github-actions github-actions bot mentioned this pull request Jul 28, 2023
Merged
abhi-markan pushed a commit that referenced this pull request Sep 13, 2023
@github-actions
chore(main): release 1.16.0 (#353)
81c2420 
🤖 I have created a release *beep* *boop*
---


##
[1.16.0](v1.15.1...v1.16.0)
(2023-09-13)


### Features

* **APIM-344:** fix 2 PR feedback items, change comment and var type
([da02c07](da02c07))
* **APIM-344:** handle sensitive details in log messages
([#324](#324))
([2e5a948](2e5a948))
* **APIM-468:** change how integer config values are parsed
([94dffdd](94dffdd))
* **APIM-468:** change how integer config values are parsed
([#357](#357))
([ee24d08](ee24d08))
* **APIM-468:** copying missed unit test for get-int-config helper
([9a2a452](9a2a452))
* **APIM-468:** merge main branch
([2ec2c5f](2ec2c5f))
* **APIM-468:** removed undefined return var type
([835b65f](835b65f))
* **APIM-468:** renaming section in unit test
([1b5cfe3](1b5cfe3))
* **apim-538:** add environment variable for log format
([#337](#337))
([fc54db2](fc54db2))
* **APIM-538:** update single line log format env var
([#365](#365))
([957c95a](957c95a))
* **APIM-582:** remove unused endpoint GET /constants/spi
([04cac62](04cac62))
* **APIM-582:** remove unused endpoint GET /constants/spi
([#427](#427))
([b431841](b431841))


### Bug Fixes

* **deps:** update all
([#396](#396))
([f851b7b](f851b7b))
* **deps:** update all
([#461](#461))
([6bf386c](6bf386c))
* **deps:** update all
([#469](#469))
([096b68b](096b68b))
* **deps:** update dependency mssql to v10
([#463](#463))
([993410d](993410d))
* **gitignore:** environment variable introduction
([#364](#364))
([3336d22](3336d22))
* **premium-schedule:** added 0 and 4 as acceptable inputs
([#440](#440))
([270b405](270b405))


### Miscellaneous

* **deps-dev:** Bump @commitlint/cli from 17.6.7 to 17.7.1
([#405](#405))
([3f5d3e6](3f5d3e6))
* **deps-dev:** Bump @commitlint/config-conventional from 17.6.7 to
17.7.0 ([#404](#404))
([febf7c3](febf7c3))
* **deps-dev:** Bump @nestjs/cli from 10.1.10 to 10.1.11
([#369](#369))
([1792ce5](1792ce5))
* **deps-dev:** Bump @nestjs/cli from 10.1.11 to 10.1.12
([#413](#413))
([167f0d3](167f0d3))
* **deps-dev:** Bump @nestjs/cli from 10.1.12 to 10.1.14
([#425](#425))
([7671347](7671347))
* **deps-dev:** Bump @nestjs/cli from 10.1.14 to 10.1.16
([#430](#430))
([dbd452e](dbd452e))
* **deps-dev:** Bump @nestjs/cli from 10.1.16 to 10.1.17
([#447](#447))
([e3deb06](e3deb06))
* **deps-dev:** Bump @nestjs/schematics from 10.0.1 to 10.0.2
([#386](#386))
([63b1159](63b1159))
* **deps-dev:** Bump @nestjs/testing from 10.1.2 to 10.1.3
([#372](#372))
([1b3f110](1b3f110))
* **deps-dev:** Bump @nestjs/testing from 10.2.1 to 10.2.4
([#448](#448))
([fa76b1c](fa76b1c))
* **deps-dev:** Bump @nestjs/testing from 10.2.4 to 10.2.5
([#474](#474))
([cee7bba](cee7bba))
* **deps-dev:** Bump @tsconfig/node20 from 20.1.0 to 20.1.1
([#394](#394))
([adb5d6c](adb5d6c))
* **deps-dev:** Bump @types/chance from 1.1.3 to 1.1.4
([#462](#462))
([4743de6](4743de6))
* **deps-dev:** Bump @types/compression from 1.7.2 to 1.7.3
([#456](#456))
([941eeaf](941eeaf))
* **deps-dev:** Bump @types/jest from 29.5.3 to 29.5.4
([#424](#424))
([821b24c](821b24c))
* **deps-dev:** Bump @types/lodash from 4.14.195 to 4.14.196
([#355](#355))
([e3ecc57](e3ecc57))
* **deps-dev:** Bump @types/lodash from 4.14.196 to 4.14.197
([#403](#403))
([31cf10f](31cf10f))
* **deps-dev:** Bump @types/lodash from 4.14.197 to 4.14.198
([#464](#464))
([902f5a6](902f5a6))
* **deps-dev:** Bump @types/node from 20.4.4 to 20.4.5
([#356](#356))
([9fe0511](9fe0511))
* **deps-dev:** Bump @types/node from 20.4.5 to 20.4.6
([#377](#377))
([babff23](babff23))
* **deps-dev:** Bump @types/node from 20.4.6 to 20.4.7
([#379](#379))
([a559dc6](a559dc6))
* **deps-dev:** Bump @types/node from 20.4.7 to 20.4.8
([#382](#382))
([ff81582](ff81582))
* **deps-dev:** Bump @types/node from 20.4.8 to 20.4.9
([#393](#393))
([fc23dfd](fc23dfd))
* **deps-dev:** Bump @types/node from 20.4.9 to 20.5.0
([#406](#406))
([da99534](da99534))
* **deps-dev:** Bump @types/node from 20.5.0 to 20.5.1
([#415](#415))
([f61b71b](f61b71b))
* **deps-dev:** Bump @types/node from 20.5.2 to 20.5.3
([#423](#423))
([1cc93c7](1cc93c7))
* **deps-dev:** Bump @types/node from 20.5.3 to 20.5.4
([9ba46d0](9ba46d0))
* **deps-dev:** Bump @types/node from 20.5.3 to 20.5.4
([#426](#426))
([62a8fa4](62a8fa4))
* **deps-dev:** Bump @types/node from 20.5.4 to 20.5.6
([#429](#429))
([8dffcc4](8dffcc4))
* **deps-dev:** Bump @types/node from 20.5.6 to 20.5.7
([#432](#432))
([a440523](a440523))
* **deps-dev:** Bump @types/node from 20.5.7 to 20.5.9
([#449](#449))
([dea29bf](dea29bf))
* **deps-dev:** Bump @types/node from 20.5.9 to 20.6.0
([#466](#466))
([b42a37c](b42a37c))
* **deps-dev:** Bump @typescript-eslint/eslint-plugin from 6.2.0 to
6.2.1 ([#368](#368))
([50db98a](50db98a))
* **deps-dev:** Bump @typescript-eslint/eslint-plugin from 6.2.1 to
6.3.0 ([#392](#392))
([8451f5f](8451f5f))
* **deps-dev:** Bump @typescript-eslint/eslint-plugin from 6.3.0 to
6.4.0 ([#409](#409))
([876dcf3](876dcf3))
* **deps-dev:** Bump @typescript-eslint/eslint-plugin from 6.4.0 to
6.4.1 ([#421](#421))
([898294e](898294e))
* **deps-dev:** Bump @typescript-eslint/eslint-plugin from 6.4.1 to
6.5.0 ([#437](#437))
([d62f78c](d62f78c))
* **deps-dev:** Bump @typescript-eslint/eslint-plugin from 6.5.0 to
6.6.0 ([#455](#455))
([7f73aca](7f73aca))
* **deps-dev:** Bump @typescript-eslint/eslint-plugin from 6.6.0 to
6.7.0 ([#475](#475))
([570e1ec](570e1ec))
* **deps-dev:** Bump @typescript-eslint/parser from 6.2.0 to 6.2.1
([#370](#370))
([1610b5d](1610b5d))
* **deps-dev:** Bump @typescript-eslint/parser from 6.2.1 to 6.3.0
([#387](#387))
([c057321](c057321))
* **deps-dev:** Bump @typescript-eslint/parser from 6.3.0 to 6.4.0
([f665ec5](f665ec5))
* **deps-dev:** Bump @typescript-eslint/parser from 6.3.0 to 6.4.0
([#410](#410))
([973d1b4](973d1b4))
* **deps-dev:** Bump @typescript-eslint/parser from 6.4.0 to 6.4.1
([#418](#418))
([217d56e](217d56e))
* **deps-dev:** Bump @typescript-eslint/parser from 6.4.1 to 6.5.0
([#439](#439))
([9709121](9709121))
* **deps-dev:** Bump @typescript-eslint/parser from 6.5.0 to 6.6.0
([#454](#454))
([984a6fd](984a6fd))
* **deps-dev:** Bump @typescript-eslint/parser from 6.6.0 to 6.7.0
([#473](#473))
([172f77a](172f77a))
* **deps-dev:** Bump cspell from 6.31.2 to 7.0.0
([#397](#397))
([c2db8eb](c2db8eb))
* **deps-dev:** Bump cspell from 7.0.1 to 7.3.2
([#459](#459))
([2922746](2922746))
* **deps-dev:** Bump cspell from 7.3.2 to 7.3.5
([#467](#467))
([8398e61](8398e61))
* **deps-dev:** Bump eslint from 8.45.0 to 8.46.0
([#366](#366))
([c458a60](c458a60))
* **deps-dev:** Bump eslint from 8.46.0 to 8.47.0
([#407](#407))
([27b53d2](27b53d2))
* **deps-dev:** Bump eslint from 8.47.0 to 8.48.0
([#434](#434))
([e79e24b](e79e24b))
* **deps-dev:** Bump eslint from 8.48.0 to 8.49.0
([#468](#468))
([7fa309a](7fa309a))
* **deps-dev:** Bump eslint-config-prettier from 8.10.0 to 9.0.0
([#385](#385))
([fab9006](fab9006))
* **deps-dev:** Bump eslint-config-prettier from 8.8.0 to 8.9.0
([#360](#360))
([5d670e6](5d670e6))
* **deps-dev:** Bump eslint-config-prettier from 8.9.0 to 8.10.0
([#378](#378))
([e537978](e537978))
* **deps-dev:** Bump eslint-import-resolver-typescript from 3.5.5 to
3.6.0 ([#401](#401))
([61046b6](61046b6))
* **deps-dev:** Bump eslint-plugin-deprecation from 1.4.1 to 1.5.0
([#359](#359))
([67b5925](67b5925))
* **deps-dev:** Bump eslint-plugin-import from 2.27.5 to 2.28.0
([#361](#361))
([db28aba](db28aba))
* **deps-dev:** Bump eslint-plugin-import from 2.28.0 to 2.28.1
([#414](#414))
([67cbce2](67cbce2))
* **deps-dev:** Bump jest from 29.6.1 to 29.6.2
([#362](#362))
([9e48aa4](9e48aa4))
* **deps-dev:** Bump jest from 29.6.3 to 29.6.4
([#428](#428))
([c6bebe0](c6bebe0))
* **deps-dev:** Bump jest-when from 3.5.2 to 3.6.0
([#390](#390))
([9a681d2](9a681d2))
* **deps-dev:** Bump lint-staged from 13.2.3 to 14.0.0
([#408](#408))
([53e95e6](53e95e6))
* **deps-dev:** Bump nock from 13.3.2 to 13.3.3
([#412](#412))
([68691b8](68691b8))
* **deps-dev:** Bump prettier from 3.0.0 to 3.0.1
([#376](#376))
([18ca5f3](18ca5f3))
* **deps-dev:** Bump prettier from 3.0.1 to 3.0.2
([a49e2d8](a49e2d8))
* **deps-dev:** Bump prettier from 3.0.1 to 3.0.2
([#411](#411))
([0db0852](0db0852))
* **deps-dev:** Bump prettier from 3.0.2 to 3.0.3
([#453](#453))
([3604468](3604468))
* **deps:** Bump @nestjs/common from 10.1.2 to 10.1.3
([#374](#374))
([1e894ec](1e894ec))
* **deps:** Bump @nestjs/common from 10.1.3 to 10.2.1
([#420](#420))
([04a3c57](04a3c57))
* **deps:** Bump @nestjs/common from 10.2.1 to 10.2.4
([#445](#445))
([ba25c47](ba25c47))
* **deps:** Bump @nestjs/common from 10.2.4 to 10.2.5
([#472](#472))
([d348287](d348287))
* **deps:** Bump @nestjs/config from 3.0.0 to 3.0.1
([#460](#460))
([698dafa](698dafa))
* **deps:** Bump @nestjs/core from 10.1.2 to 10.1.3
([#371](#371))
([c5fe5e8](c5fe5e8))
* **deps:** Bump @nestjs/core from 10.1.3 to 10.2.1
([#422](#422))
([07ebd1a](07ebd1a))
* **deps:** Bump @nestjs/core from 10.2.1 to 10.2.4
([#444](#444))
([ac39fea](ac39fea))
* **deps:** Bump @nestjs/core from 10.2.4 to 10.2.5
([#471](#471))
([465ecbb](465ecbb))
* **deps:** Bump @nestjs/platform-express from 10.1.2 to 10.1.3
([#367](#367))
([9f4f39e](9f4f39e))
* **deps:** Bump @nestjs/platform-express from 10.2.1 to 10.2.4
([#446](#446))
([eea2eca](eea2eca))
* **deps:** Bump @nestjs/swagger from 7.1.4 to 7.1.6
([#373](#373))
([af02e9e](af02e9e))
* **deps:** Bump @nestjs/swagger from 7.1.6 to 7.1.7
([d96991e](d96991e))
* **deps:** Bump @nestjs/swagger from 7.1.6 to 7.1.7
([#383](#383))
([a1a9193](a1a9193))
* **deps:** Bump @nestjs/swagger from 7.1.7 to 7.1.8
([#400](#400))
([922b4f3](922b4f3))
* **deps:** Bump @nestjs/swagger from 7.1.8 to 7.1.10
([#450](#450))
([edea88d](edea88d))
* **deps:** Bump axios from 1.4.0 to 1.5.0
([#433](#433))
([7de0b1e](7de0b1e))
* **deps:** Bump Azure/cli from 1.0.7 to 1.0.8
([#389](#389))
([0b07a64](0b07a64))
* **deps:** Bump mssql from 9.1.1 to 9.1.2
([#375](#375))
([19a2e04](19a2e04))
* **deps:** Bump mssql from 9.1.2 to 9.1.3
([#388](#388))
([cc47ab3](cc47ab3))
* **deps:** Bump mssql from 9.1.3 to 9.2.0
([#451](#451))
([d93303a](d93303a))
* **deps:** Bump mssql from 9.2.0 to 10.0.0
([#458](#458))
([ef403eb](ef403eb))
* **deps:** Bump nestjs-pino from 3.3.0 to 3.4.0
([#419](#419))
([defde0e](defde0e))
* **deps:** Bump node from 20.5.0-alpine3.17 to 20.5.1-alpine3.17
([#398](#398))
([903d631](903d631))
* **deps:** Bump node from 20.6.0-alpine3.17 to 20.6.1-alpine3.17
([#470](#470))
([616dc47](616dc47))
* **deps:** Bump pino-http from 8.3.3 to 8.4.0
([dc7c1d0](dc7c1d0))
* **deps:** Bump pino-http from 8.3.3 to 8.4.0
([#384](#384))
([310756b](310756b))
* **deps:** Bump pino-http from 8.4.0 to 8.5.0
([#457](#457))
([f8f64da](f8f64da))
* **deps:** Bump pino-pretty from 10.1.0 to 10.2.0
([#354](#354))
([c9e0418](c9e0418))
* **deps:** Bump tslib from 2.6.1 to 2.6.2
([#416](#416))
([be2d437](be2d437))
* **deps:** Bump typeorm-extension from 3.0.0 to 3.0.1
([#363](#363))
([d0ae7ab](d0ae7ab))
* **deps:** Bump typescript from 5.1.6 to 5.2.2
([#431](#431))
([f27ae39](f27ae39))
* **deps:** update actions/checkout action to v4
([#452](#452))
([f5f1fba](f5f1fba))
* **deps:** update all
([#417](#417))
([4cf5076](4cf5076))
* **deps:** update dependency jest to v29.7.0
([#476](#476))
([4c5a4a7](4c5a4a7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@abhi-markan abhi-markan mentioned this pull request May 22, 2024
Merged
abhi-markan added a commit that referenced this pull request May 22, 2024
@abhi-markan
chore(main): release 1.19.0 (#890)
0d2a919 
🤖 I have created a release *beep* *boop*
---


##
[1.19.0](v1.18.0...v1.19.0)
(2024-05-22)


### Features

* **ami:** migration to Azure AMI
([9854d57](9854d57))
* **ami:** migration to Azure AMI
([#514](#514))
([bfeaa1e](bfeaa1e))
* **APIM-344:** added test to redact using regex in
'redactStringsInLogArgs'
([709477d](709477d))
* **APIM-344:** changed redaction in crashed bootstrap and changed
redaction in recovered bootstrap
([3a3b646](3a3b646))
* **APIM-344:** fix 2 PR feedback items, change comment and var type
([da02c07](da02c07))
* **APIM-344:** handle sensitive details in log messages
([#324](#324))
([2e5a948](2e5a948))
* **APIM-344:** unit test for logger class ConsoleLoggerWithRedact
([4950a04](4950a04))
* **APIM-344:** use process variable to enable/disable redacting at
bootstrap
([f1c101a](f1c101a))
* **APIM-468:** change how integer config values are parsed
([94dffdd](94dffdd))
* **APIM-468:** change how integer config values are parsed
([#357](#357))
([ee24d08](ee24d08))
* **APIM-468:** copying missed unit test for get-int-config helper
([9a2a452](9a2a452))
* **APIM-468:** merge main branch
([2ec2c5f](2ec2c5f))
* **APIM-468:** removed undefined return var type
([835b65f](835b65f))
* **APIM-468:** renaming section in unit test
([1b5cfe3](1b5cfe3))
* **apim-538:** add environment variable for log format
([#337](#337))
([fc54db2](fc54db2))
* **APIM-538:** update single line log format env var
([#365](#365))
([957c95a](957c95a))
* **APIM-582:** remove unused endpoint GET /constants/spi
([04cac62](04cac62))
* **APIM-582:** remove unused endpoint GET /constants/spi
([#427](#427))
([b431841](b431841))
* **DTFS-7052:** added GET `/geospatial/addresses/postcode` endpoint for
Ordnance Survey API data
([#804](#804))
([4963371](4963371))
* **DTFS2-7049:** adding new env variables to docker-compose.yml
([3ca57f0](3ca57f0))
* **DTFS2-7052:** actioning PR comments
([e012eb4](e012eb4))
* **DTFS2-7052:** actioning PR comments
([7d15b07](7d15b07))
* **DTFS2-7052:** adding constants and examples
([a3d5433](a3d5433))
* **DTFS2-7052:** adding typescript include for json files, to satify
lint. I added big examples to json files
([0b79772](0b79772))
* **DTFS2-7052:** api-tests for geospatial/get-address-by-postcode
([c8cb1bc](c8cb1bc))
* **DTFS2-7052:** applying Oscars suggestions on my PR
([f68ac66](f68ac66))
* **DTFS2-7052:** change GET /geospatial/addresses/postcode?postcode=
empty response from 200 to 404
([33c9e65](33c9e65))
* **DTFS2-7052:** change husky install to same way as in DTFS project
([889fe1b](889fe1b))
* **DTFS2-7052:** changed documentation for .env setting
ORDNANCE_SURVEY_URL
([18fdf4a](18fdf4a))
* **DTFS2-7052:** changed numeric status code 200 to HttpStatus.OK, but
just in controller
([3751992](3751992))
* **DTFS2-7052:** changing variables to use plural
([c020867](c020867))
* **DTFS2-7052:** code style improvements based on PR feedback
([38939db](38939db))
* **DTFS2-7052:** comments copy and variable name improvements
([5a0ee93](5a0ee93))
* **DTFS2-7052:** downgrade @commitlint/cli from 19.3.0 to 18.6.0
([132d179](132d179))
* **DTFS2-7052:** fix address line 1 formating
([db50210](db50210))
* **DTFS2-7052:** fixed lint errors
([17fea54](17fea54))
* **DTFS2-7052:** improve address test data
([ff5ac7b](ff5ac7b))
* **DTFS2-7052:** moving address examples to constants
([de7a0e5](de7a0e5))
* **DTFS2-7052:** moving uk postcode regex to constants and doc
improvements
([75b34ac](75b34ac))
* **DTFS2-7052:** new API modules and endpoint
/api/v1/geospatial/addresses/postcode?postcode=W1A1AA
([2cdd0de](2cdd0de))
* **DTFS2-7052:** new module geospatial
([14a6a08](14a6a08))
* **DTFS2-7052:** package update
([3259347](3259347))
* **DTFS2-7052:** refactor api tests to match TFS and solve type issues
([c91144d](c91144d))
* **DTFS2-7052:** removing unused class
GetSearchPostcodeOrdnanceSurveyQueryDto
([32aa1ef](32aa1ef))
* **DTFS2-7052:** renaming enums/geospatial.ts to
enums/geospatialCountries.ts
([252b5a1](252b5a1))
* **DTFS2-7052:** spelling fix
([4c503ca](4c503ca))
* **DTFS2-7052:** tests for ordnance survey API endpoint
([837a482](837a482))
* **DTFS2-7052:** tidying up map function
([0da25c3](0da25c3))
* **DTFS2-7052:** trying to automate husky run on commit
([5fbf3d7](5fbf3d7))
* **DTFS2-7052:** trying to automate husky run on commit
([1b6cf30](1b6cf30))
* **DTFS2-7052:** typescript type improvement in api-test helper
([6bf5a4d](6bf5a4d))
* **DTFS2-7052:** updating API spec
([15743c0](15743c0))
* **DTFS2-7052:** updating api spec definition
([fa73657](fa73657))
* **DTFS2-7052:** updating api spec snapshot
([3e215d7](3e215d7))
* **DTFS2-7052:** updating spec snapshot
([c7ac787](c7ac787))
* **DTFS2-7052:** work in progress of geospatial-get-address api tests
([21f8006](21f8006))
* **github-actions:** enable various imperative github actions
([#847](#847))
([fbfafa9](fbfafa9))
* **release-please-v4:** updated release-please to v4
[#491](#491)
([#688](#688))
([cc07b84](cc07b84))
* **template:** pull request template
([b8506bb](b8506bb))
* **template:** pull request template
([#624](#624))
([847bdeb](847bdeb))


### Bug Fixes

* **ci:** run ci with legacy-peer-deps argument
([d77d8f3](d77d8f3))
* **deps:** update all
([#396](#396))
([f851b7b](f851b7b))
* **deps:** update all
([#461](#461))
([6bf386c](6bf386c))
* **deps:** update all
([#469](#469))
([096b68b](096b68b))
* **deps:** update dependency @nestjs/swagger to v7.1.2
([#331](#331))
([db807a6](db807a6))
* **deps:** update dependency mssql to v10
([#463](#463))
([993410d](993410d))
* **deps:** update dependency tslib to v2.6.1
([#338](#338))
([824cc52](824cc52))
* **deps:** upgrade pino-http to 10.0.0
([#888](#888))
([fac01d4](fac01d4))
* **env:** updated .env.sample
([bd3f594](bd3f594))
* **env:** updated `.env.sample`
([#516](#516))
([c09f145](c09f145))
* **format:** formatting fixes
([b14807a](b14807a))
* **format:** Formatting fixes
([#517](#517))
([baa3713](baa3713))
* **gitignore:** environment variable introduction
([#364](#364))
([3336d22](3336d22))
* **iac:** ACR
([#343](#343))
([51d2316](51d2316))
* **premium-schedule:** added 0 and 4 as acceptable inputs
([#440](#440))
([270b405](270b405))
* **release-please-version:** set version to v1.17.0
([#689](#689))
([90c6b08](90c6b08))
* **release:** release version manager
([#532](#532))
([8a2a3a2](8a2a3a2))
* **spellcheck:** added spellcheck to the pipeline
([#511](#511))
([8b84855](8b84855))
* **tsconfig:** fixed tsconfig file
([d8df948](d8df948))
* **tsconfig:** tsconfig file fix
([e470ec5](e470ec5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Abhi Markan <amarkan@ukexportfinance.gov.uk>
@abhi-markan abhi-markan mentioned this pull request May 22, 2024
Merged
abhi-markan added a commit that referenced this pull request May 22, 2024
@abhi-markan
chore(main): release 1.20.0 (#892)
5c73e66 
🤖 I have created a release *beep* *boop*
---


##
[1.20.0](v1.19.0...v1.20.0)
(2024-05-22)


### Features

* **ami:** migration to Azure AMI
([9854d57](9854d57))
* **ami:** migration to Azure AMI
([#514](#514))
([bfeaa1e](bfeaa1e))
* **APIM-344:** added test to redact using regex in
'redactStringsInLogArgs'
([709477d](709477d))
* **APIM-344:** fix 2 PR feedback items, change comment and var type
([da02c07](da02c07))
* **APIM-344:** handle sensitive details in log messages
([#324](#324))
([2e5a948](2e5a948))
* **APIM-344:** use process variable to enable/disable redacting at
bootstrap
([f1c101a](f1c101a))
* **APIM-468:** change how integer config values are parsed
([94dffdd](94dffdd))
* **APIM-468:** change how integer config values are parsed
([#357](#357))
([ee24d08](ee24d08))
* **APIM-468:** copying missed unit test for get-int-config helper
([9a2a452](9a2a452))
* **APIM-468:** merge main branch
([2ec2c5f](2ec2c5f))
* **APIM-468:** removed undefined return var type
([835b65f](835b65f))
* **APIM-468:** renaming section in unit test
([1b5cfe3](1b5cfe3))
* **apim-538:** add environment variable for log format
([#337](#337))
([fc54db2](fc54db2))
* **APIM-538:** update single line log format env var
([#365](#365))
([957c95a](957c95a))
* **APIM-582:** remove unused endpoint GET /constants/spi
([04cac62](04cac62))
* **APIM-582:** remove unused endpoint GET /constants/spi
([#427](#427))
([b431841](b431841))
* **DTFS-7052:** added GET `/geospatial/addresses/postcode` endpoint for
Ordnance Survey API data
([#804](#804))
([4963371](4963371))
* **DTFS2-7049:** adding new env variables to docker-compose.yml
([3ca57f0](3ca57f0))
* **DTFS2-7052:** actioning PR comments
([e012eb4](e012eb4))
* **DTFS2-7052:** actioning PR comments
([7d15b07](7d15b07))
* **DTFS2-7052:** adding constants and examples
([a3d5433](a3d5433))
* **DTFS2-7052:** adding typescript include for json files, to satify
lint. I added big examples to json files
([0b79772](0b79772))
* **DTFS2-7052:** api-tests for geospatial/get-address-by-postcode
([c8cb1bc](c8cb1bc))
* **DTFS2-7052:** applying Oscars suggestions on my PR
([f68ac66](f68ac66))
* **DTFS2-7052:** change GET /geospatial/addresses/postcode?postcode=
empty response from 200 to 404
([33c9e65](33c9e65))
* **DTFS2-7052:** change husky install to same way as in DTFS project
([889fe1b](889fe1b))
* **DTFS2-7052:** changed documentation for .env setting
ORDNANCE_SURVEY_URL
([18fdf4a](18fdf4a))
* **DTFS2-7052:** changed numeric status code 200 to HttpStatus.OK, but
just in controller
([3751992](3751992))
* **DTFS2-7052:** changing variables to use plural
([c020867](c020867))
* **DTFS2-7052:** code style improvements based on PR feedback
([38939db](38939db))
* **DTFS2-7052:** comments copy and variable name improvements
([5a0ee93](5a0ee93))
* **DTFS2-7052:** downgrade @commitlint/cli from 19.3.0 to 18.6.0
([132d179](132d179))
* **DTFS2-7052:** fix address line 1 formating
([db50210](db50210))
* **DTFS2-7052:** fixed lint errors
([17fea54](17fea54))
* **DTFS2-7052:** improve address test data
([ff5ac7b](ff5ac7b))
* **DTFS2-7052:** moving address examples to constants
([de7a0e5](de7a0e5))
* **DTFS2-7052:** moving uk postcode regex to constants and doc
improvements
([75b34ac](75b34ac))
* **DTFS2-7052:** new API modules and endpoint
/api/v1/geospatial/addresses/postcode?postcode=W1A1AA
([2cdd0de](2cdd0de))
* **DTFS2-7052:** new module geospatial
([14a6a08](14a6a08))
* **DTFS2-7052:** package update
([3259347](3259347))
* **DTFS2-7052:** refactor api tests to match TFS and solve type issues
([c91144d](c91144d))
* **DTFS2-7052:** removing unused class
GetSearchPostcodeOrdnanceSurveyQueryDto
([32aa1ef](32aa1ef))
* **DTFS2-7052:** renaming enums/geospatial.ts to
enums/geospatialCountries.ts
([252b5a1](252b5a1))
* **DTFS2-7052:** spelling fix
([4c503ca](4c503ca))
* **DTFS2-7052:** tests for ordnance survey API endpoint
([837a482](837a482))
* **DTFS2-7052:** tidying up map function
([0da25c3](0da25c3))
* **DTFS2-7052:** trying to automate husky run on commit
([5fbf3d7](5fbf3d7))
* **DTFS2-7052:** trying to automate husky run on commit
([1b6cf30](1b6cf30))
* **DTFS2-7052:** typescript type improvement in api-test helper
([6bf5a4d](6bf5a4d))
* **DTFS2-7052:** updating API spec
([15743c0](15743c0))
* **DTFS2-7052:** updating api spec definition
([fa73657](fa73657))
* **DTFS2-7052:** updating api spec snapshot
([3e215d7](3e215d7))
* **DTFS2-7052:** updating spec snapshot
([c7ac787](c7ac787))
* **DTFS2-7052:** work in progress of geospatial-get-address api tests
([21f8006](21f8006))
* **github-actions:** enable various imperative github actions
([#847](#847))
([fbfafa9](fbfafa9))
* **release-please-v4:** updated release-please to v4
[#491](#491)
([#688](#688))
([cc07b84](cc07b84))
* **template:** pull request template
([b8506bb](b8506bb))
* **template:** pull request template
([#624](#624))
([847bdeb](847bdeb))


### Bug Fixes

* **ci:** run ci with legacy-peer-deps argument
([d77d8f3](d77d8f3))
* **deps:** update all
([#396](#396))
([f851b7b](f851b7b))
* **deps:** update all
([#461](#461))
([6bf386c](6bf386c))
* **deps:** update all
([#469](#469))
([096b68b](096b68b))
* **deps:** update dependency @nestjs/swagger to v7.1.2
([#331](#331))
([db807a6](db807a6))
* **deps:** update dependency mssql to v10
([#463](#463))
([993410d](993410d))
* **deps:** update dependency tslib to v2.6.1
([#338](#338))
([824cc52](824cc52))
* **deps:** upgrade pino-http to 10.0.0
([#888](#888))
([fac01d4](fac01d4))
* **env:** updated .env.sample
([bd3f594](bd3f594))
* **env:** updated `.env.sample`
([#516](#516))
([c09f145](c09f145))
* **format:** formatting fixes
([b14807a](b14807a))
* **format:** Formatting fixes
([#517](#517))
([baa3713](baa3713))
* **gitignore:** environment variable introduction
([#364](#364))
([3336d22](3336d22))
* **iac:** ACR
([#343](#343))
([51d2316](51d2316))
* **premium-schedule:** added 0 and 4 as acceptable inputs
([#440](#440))
([270b405](270b405))
* **release-please-version:** set version to v1.17.0
([#689](#689))
([90c6b08](90c6b08))
* **release-please:** changed to GitHub plugin
([#891](#891))
([8f3b044](8f3b044))
* **release:** release version manager
([#532](#532))
([8a2a3a2](8a2a3a2))
* **spellcheck:** added spellcheck to the pipeline
([#511](#511))
([8b84855](8b84855))
* **tsconfig:** fixed tsconfig file
([d8df948](d8df948))
* **tsconfig:** tsconfig file fix
([e470ec5](e470ec5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarrai-sw lmarrai-sw lmarrai-sw approved these changes

@abhi-markan abhi-markan Awaiting requested review from abhi-markan

@AlexBramhill AlexBramhill Awaiting requested review from AlexBramhill

@francescastocco francescastocco Awaiting requested review from francescastocco

@oscar-richardson-softwire oscar-richardson-softwire Awaiting requested review from oscar-richardson-softwire

@IgnatG IgnatG Awaiting requested review from IgnatG

Assignees
No one assigned
Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avaitonis @IgnatG @lmarrai-sw