Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(2997) Include ODA type in ISPF report export filenames #2268

Merged
merged 1 commit into from
Nov 30, 2023
Merged

(2997) Include ODA type in ISPF report export filenames #2268

merged 1 commit into from
Nov 30, 2023

Conversation

CristinaRO
Copy link
Contributor

Changes in this PR

  • ISPF report CSVs now include the ODA type, to make it easier for users to distinguish between them.

Screenshots of UI changes

N/A

Next steps

  • Is an ADR required? An ADR should be added if this PR introduces a change to the architecture.
  • Is a changelog entry required? An entry should always be made in CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.
  • Do any environment variables need amending or adding?
  • Have any changes to the XML been checked with the IATI validator? See XML Validation

@CristinaRO
Include ODA type in ISPF report export filenames
c733821 
ISPF report CSVs now include the ODA type, to make it easier for users
to distinguish between them.
@CristinaRO
Copy link
Contributor Author

The filename of the CSV report export for ISPF should include ODA/non-ODA

mec
mec approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@mec mec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@CristinaRO CristinaRO merged commit d843137 into develop Nov 30, 2023
4 checks passed
@CristinaRO CristinaRO deleted the 2997-the-filename-of-the-csv-report branch November 30, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mec mec mec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CristinaRO @mec