improve(emp): Match synthetic and collateral precision #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Pai <npai.nyc@gmail.com> update tests, remove bytecode Signed-off-by: Nick Pai <npai.nyc@gmail.com> update liquidator tests Signed-off-by: Nick Pai <npai.nyc@gmail.com> wip Signed-off-by: Nick Pai <npai.nyc@gmail.com> Revert "wip" This reverts commit 3820b4f. Revert "update tests, remove bytecode" This reverts commit 5c66a42. update ppm tests Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
nicholaspai
commented
Nov 3, 2020
| @@ -1919,9 +1919,6 @@ contract("PerpetualLiquidatable", function(accounts) { | |||
| await syntheticToken.addMinter(USDCLiquidationContract.address); | |||
| await syntheticToken.addBurner(USDCLiquidationContract.address); | |||
|
|
|||
| // Get newly created synthetic token and set it as the global synthetic token. | |||
| syntheticToken = await Token.at(await USDCLiquidationContract.tokenCurrency()); | |||
There was a problem hiding this comment.
This is uneccessary since we now create syntheticToken at top of section.
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
mrice32
changed the title
chrismaree
approved these changes
Nov 4, 2020
packages/core/contracts/financial-templates/expiring-multiparty/ExpiringMultiPartyCreator.sol
Outdated
Show resolved
Hide resolved
packages/core/test/financial-templates/expiring-multiparty/ExpiringMultiPartyCreator.js
Outdated
Show resolved
Hide resolved
…iringMultiPartyCreator.js Co-authored-by: Chris Maree <christopher.maree@gmail.com>
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
daywiss
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Parallels implementation #2119 for the EMP.
Summary
Refactors SyntheticToken creation out of the EMP and into the EMPCreator to save bytecode. Bytecode is added so that EMP contract dynamically sets the SyntheticToken precision based on the collateral token's precision.
Issue(s)
Fixes #2144