Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okay I there were missing some values in the tree morphology file. After fixing this it worked! #462

Closed
shahjahan0275 opened this issue Oct 5, 2022 · 26 comments
Assignees

Comments

@shahjahan0275
Copy link

    okay I there were missing some values in the tree morphology file. After fixing this it worked! 

But now QGIS still craches when using SUEWS advanced even with strongly reduced time period and cell number. The supy log just says '2020-12-22 19:24:54,578 - SuPy - INFO - All cache cleared.'

I will attach my SUEWS prepare results. Would be great if you can at least check weather it works at your side or not.

prepare_klein1.zip

Originally posted by @flgebhardt in #207 (comment)

@shahjahan0275
Copy link
Author

I am also facing the same problem with SUEWS prepare. can you please tell me which " values in the tree morphology file" that you have fixed to solve the issue.

@biglimp
Copy link
Contributor

biglimp commented Oct 6, 2022

Before we move on, could you please try to run SUEWS from UMEP for processing first and report back the result.

@shahjahan0275
Copy link
Author

I could not prepare the data to run SUEWS using "SUEWS prepare" due to that problem. So how can I run SUEWS from UMEP for processing with out prepared data

@shahjahan0275
Copy link
Author

So I am facing this problem
python/plugins\UMEP\SUEWSPrepare\prepare_worker.py,
LINE 425 "zH = (float(IMP_heights_mean) * LCF_bu + float(IMPveg_heights_mean_eve) * LCF_ev + float(IMPveg_heights_mean_dec) * LCF_de) / (LCF_bu + LCF_ev + LCF_de)"
ERROR MESSAGE: local variable 'IMPveg_max_dec' referenced before assignment

I am using QGIS 3.26.3
May I know "What are the values that you missed in the tree morphology file"
Regards

@shahjahan0275
Copy link
Author

is there any problem in the "prepare_worker.py" to show the error above?

@biglimp
Copy link
Contributor

biglimp commented Oct 7, 2022

Ok, now I understand a bit better.

Can you attach your files that you use in SUEWSPrepare and your settings for vegetation, i.e. are you using both deciduous and confier.

@shahjahan0275
Copy link
Author

@shahjahan0275
Copy link
Author

These are the files that I used in SUEWS prepare. I was exactly following this tutorial
https://umep-docs.readthedocs.io/projects/tutorial/en/latest/Tutorials/SuewsWUDAPT.html#suewswudapt

@biglimp
Copy link
Contributor

biglimp commented Oct 7, 2022

I need your grid also (shapefile).

@shahjahan0275
Copy link
Author

SUEWSWUDAPT_NYC.zip

@shahjahan0275
Copy link
Author

All the grid (shapefile) is in the zip. Regards

biglimp added a commit that referenced this issue Oct 11, 2022
Response to #461 and #462
@biglimp
Copy link
Contributor

biglimp commented Oct 11, 2022

Found the bug. Should be fixed now. It will probably take some time before new version is available in QGIS repo. Use Development Release is you cannot wait.

@biglimp biglimp closed this as completed Oct 11, 2022
@shahjahan0275
Copy link
Author

I am facing following problem while running UMEP > Processer > Urban Energy Balance > Urban Energy Balance (SUEWS/BLUEWS, advanced). I am following the same tutorial as before:
https://umep-docs.readthedocs.io/projects/tutorial/en/latest/Tutorials/SuewsWUDAPT.html#suewswudapt
image

attaching supy log also:

SuPy.log

@biglimp
Copy link
Contributor

biglimp commented Oct 19, 2022

What version of UMEP are you using. THis might have been fixed in the latest version.

@shahjahan0275
Copy link
Author

I am using the following version:
UMEP Available version (stable) 3.20.7 updated at Tue Oct 11 02:56:13 2022

@biglimp
Copy link
Contributor

biglimp commented Oct 20, 2022

Can also please check your version of SuPy. Should be displayed as a log message in QGIS.

biglimp added a commit that referenced this issue Oct 20, 2022
3.20.8: Response to #462
@biglimp
Copy link
Contributor

biglimp commented Oct 20, 2022

I think I found the issue. Updated to 3.20.8. Install as a development release (https://umep-docs.readthedocs.io/en/latest/Getting_Started.html#installing-development-release-could-be-unstable). You need to go back in the tutorial and re-run SUEWS Prepare.

@shahjahan0275
Copy link
Author

I have followed your instruction. same error:
image
SuPy.log

@biglimp
Copy link
Contributor

biglimp commented Oct 21, 2022

What.version of SuPy do you have?

@biglimp biglimp reopened this Oct 21, 2022
biglimp added a commit that referenced this issue Oct 24, 2022
@biglimp
Copy link
Contributor

biglimp commented Oct 24, 2022

Ok, new try. Download latest development release and try again.

@shahjahan0275
Copy link
Author

image
I have 32 GB installed memory on my laptop.

@biglimp
Copy link
Contributor

biglimp commented Oct 25, 2022

First things first, did we get rid of the other error? This is a new one?

@shahjahan0275
Copy link
Author

shahjahan0275 commented Oct 25, 2022 via email

@biglimp
Copy link
Contributor

biglimp commented Oct 25, 2022

@sunt05, what do you make of this last error?

@biglimp
Copy link
Contributor

biglimp commented Oct 25, 2022

hm, this error is produced from one of our tutorials which worked before SuPy. We need to find a solution to this.

@sunt05
Copy link
Contributor

sunt05 commented Oct 25, 2022

Yes, there are no other error, SUEWS ran for quite some time, then this error occurred. Regards

@shahjahan0275 Thanks for the update - then please close this issue and follow up on the new one.

@biglimp to me, this seems to be an upstream issue as explained in the issue referenced here.

@biglimp biglimp closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants