-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Singularity QuickByte #8
Conversation
I changed the maroon colors to navy. I also updated the <tt> tags to <code> tags. I read that <tt> is deprecated and not supported universally, but I don't know if it was necessary for me to change or not. There was an issue ending a <tt> code segment with <\tt> resulting in everything after a certain chunk being in code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just changed colors and tags. Added some italics to file names so that it seemed more consistent.
Missed a tag
Again, missed closing a tag. Last time I promise... Also, was not aware that html tags in this comment area show up once published.
Ends kind of abruptly after the section about mapping directories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used a simple print "hello" world program
docker run -v < path to test_party.R folder >:/mnt r_party Rscript /mnt/test_party.R
The 'r_party' is missing in the command.
The command for converting docker to singularity image should be
docker run -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/output --privileged -t --rm singularityware/docker2singularity r_party
I will go ahead and edit the above comments.
In the last mapping directories command,
r_.simg >> r_party.simg
Do not explain process_lidar.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready for publication.
@savinshynu Hi Savin, if this looks good, can you please approve it and merge? Thank you |
The suggested changes are not implemented in the html file. |
I will convert this to Markdown today and implement Savin's comments. |
@gmfricke When I convert to markdown I am going to lose all the color coding. Is that okay? Or do we want to just keep this one in html? |
That’s completely fine.
From: liphardt <notifications@github.com>
Reply-To: UNM-CARC/QuickBytes <reply@reply.github.com>
Date: Friday, March 8, 2019 at 11:53 AM
To: UNM-CARC/QuickBytes <QuickBytes@noreply.github.com>
Cc: Matthew Fricke <matthew@fricke.co.uk>, Mention <mention@noreply.github.com>
Subject: Re: [UNM-CARC/QuickBytes] Singularity QuickByte (#8)
@gmfricke<https://github.com/gmfricke> When I convert to markdown I am going to lose all the color coding. Is that okay? Or do we want to just keep this one in html?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#8 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADw5Ew4EhaMdrJfMntut-WNhHWIqN8gnks5vUrGLgaJpZM4bABZr>.
|
I converted the html version to markdown to keep with our current theme.
renamed to add .md extension hoping github recognizes that now and it displays properly.
markdown version of Matthew's singularity image
No description provided.