Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singularity QuickByte #8

Closed
wants to merge 14 commits into from
Closed

Singularity QuickByte #8

wants to merge 14 commits into from

Conversation

gmfricke
Copy link
Collaborator

No description provided.

I changed the maroon colors to navy. I also updated the <tt> tags to <code> tags. I read that <tt> is deprecated and not supported universally, but I don't know if it was necessary for me to change or not. There was an issue ending a <tt> code segment with <\tt> resulting in everything after a certain chunk being in code.
Copy link
Contributor

@liphardt liphardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changed colors and tags. Added some italics to file names so that it seemed more consistent.

Again, missed closing a tag. Last time I promise...
Also, was not aware that html tags in this comment area show up once published.
@liphardt
Copy link
Contributor

Ends kind of abruptly after the section about mapping directories.

Copy link
Contributor

@savinshynu savinshynu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used a simple print "hello" world program
docker run -v < path to test_party.R folder >:/mnt r_party Rscript /mnt/test_party.R
The 'r_party' is missing in the command.

The command for converting docker to singularity image should be
docker run -v /var/run/docker.sock:/var/run/docker.sock -v /tmp:/output --privileged -t --rm singularityware/docker2singularity r_party
I will go ahead and edit the above comments.

In the last mapping directories command,
r_.simg >> r_party.simg
Do not explain process_lidar.R

Copy link
Contributor

@liphardt liphardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready for publication.

@ceodspspectrum
Copy link
Contributor

@savinshynu Hi Savin, if this looks good, can you please approve it and merge? Thank you

@savinshynu
Copy link
Contributor

The suggested changes are not implemented in the html file.

@liphardt
Copy link
Contributor

liphardt commented Mar 8, 2019

I will convert this to Markdown today and implement Savin's comments.

@liphardt
Copy link
Contributor

liphardt commented Mar 8, 2019

@gmfricke When I convert to markdown I am going to lose all the color coding. Is that okay? Or do we want to just keep this one in html?

@gmfricke
Copy link
Collaborator Author

gmfricke commented Mar 8, 2019 via email

liphardt and others added 3 commits March 8, 2019 17:59
I converted the html version to markdown to keep with our current theme.
renamed to add .md extension hoping github recognizes that now and it displays properly.
markdown version of Matthew's singularity image
@gmfricke gmfricke closed this Mar 9, 2019
@liphardt liphardt deleted the singularity-quickbyte branch February 4, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants