Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch build system to using poetry #133

Merged
merged 20 commits into from
Jun 16, 2022
Merged

Conversation

bobmoretti
Copy link
Collaborator

Switch Python build system to use poetry instead of virtualenv/shell

I really hate a lot of things about virtualenv. Seems that the "poetry" project for Python is the least bad of all the alternatives.

This also (mostly) obviates the need for shell scripts. Unfortunately I had a hell of a time getting the github actions runner instances to run shell commands inside Python scripts, so I gave up on doing that and just duplicated some of the functionality inside of the action yaml.

I also somehow ended up updating a bunch of frontend stuff, which led me down a chain of fixing a bunch of eslint warnings and removing all explicit uses of any from the code. It's more type safe now.

Before we could close this PR I would need to update the developer docs.

@bobmoretti
Copy link
Collaborator Author

Actually, I'm not sure if there are any developer docs. So I should probably write some.

@adamdoda
Copy link
Contributor

We used to have something but I guess I've removed it.

@bobmoretti bobmoretti marked this pull request as ready for review June 14, 2022 20:46
doc/Development.md Show resolved Hide resolved
@bobmoretti
Copy link
Collaborator Author

All tests passing, updated documentation, had to do something slightly awkward with the pydcs data files and pyinstaller, but I should be able to make a change upstream in pydcs to obviate that.

@bobmoretti bobmoretti requested a review from adamdoda June 16, 2022 17:55
@bobmoretti bobmoretti merged commit 7b8b88e into master Jun 16, 2022
@bobmoretti bobmoretti deleted the user/bobmoretti/poetry branch June 16, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants