Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARKLER 33] Disable kafka by default with kafka.enabled parameter #35

Merged
merged 1 commit into from
Sep 27, 2016
Merged

[SPARKLER 33] Disable kafka by default with kafka.enabled parameter #35

merged 1 commit into from
Sep 27, 2016

Conversation

rahulpalamuttam
Copy link
Contributor

@rahulpalamuttam rahulpalamuttam commented Sep 25, 2016 •
edited
Loading

The following PR addresses issue #33

  1. kafka.enabled parameter has been added with default value as false.
    Note that the yaml class reads this in as a boolean.
  2. The config parameter is checked before sending content to kafka

@thammegowda @karanjeets

karanjeets
karanjeets approved these changes Sep 27, 2016
View reviewed changes
Copy link
Member

@karanjeets karanjeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Rahul 👍

@karanjeets karanjeets merged commit 8009dbe into USCDataScience:master Sep 27, 2016
buggtb added a commit that referenced this pull request Oct 7, 2021
@buggtb
Merge pull request #35 from spicule-kythera/mvn2sbt
9549a29 
update versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanjeets karanjeets karanjeets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulpalamuttam @karanjeets