Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract and store impact assessment methods #5

Closed
WesIngwersen opened this issue Aug 25, 2022 · 6 comments
Closed

Extract and store impact assessment methods #5

WesIngwersen opened this issue Aug 25, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@WesIngwersen
Copy link
Collaborator

WesIngwersen commented Aug 25, 2022

Extract these methods
image

Put into a the LCIAformatter LCIAMethod format

@WesIngwersen WesIngwersen added the enhancement New feature or request label Aug 25, 2022
@WesIngwersen WesIngwersen changed the title Extract and store impact assessment methods in a C matrix Extract and store impact assessment methods Aug 26, 2022
@a-w-beck
Copy link
Contributor

a-w-beck commented Aug 31, 2022

@bl-young two questions in preparation for lciafmt ingestion:

  1. Looking at the new LCIA methods file, do we need to map the elementary flows to FEDEFL to get the needed Context values?
  2. Are the "Item(s)" and/or "Jobs" units associated with the Jobs and Labor Hours economic flows appropriate? Or would FEDEFL mapping resolve this too? I ask because the LCIAMethod mentions the flow unit field "uses olca-ipc.py units", within which I don't see "Jobs".

@bl-young
Copy link
Collaborator

@a-w-beck Lciafmt handles both those things.

@a-w-beck
Copy link
Contributor

Also @WesIngwersen I've excluded the "WARM (MTCE)" method and factors from the methods file because they are defined on the "GHGs" impact category, which has indicator units of MTCO2E (rather than MTCE).

The factor values look correct (i.e., scaled by 0.27 vs the true MTCO2E factors), but just wanted to offer a heads-up.

@WesIngwersen
Copy link
Collaborator Author

@a-w-beck I don't think there is a need to exclude the method.. I understand it doesn't provide a lot of additional info, but it is used in WARM

@bl-young
Copy link
Collaborator

bl-young commented Sep 1, 2022

I've got the initial script in place to apply this in the lciafmt. I few things to note based on what came out of warm in f8b3a75.

  • The reference unit and the name in openLCA for WARM (Labor hours) is wrong. It says Jobs but it should be Labor hours
  • The units during flow mapping are proving somewhat tricky. LCIAfmt will defer to mapping when the source UUID matches so it basically ignores context and unit. However in openLCA the unit that gets exported for the indicators does not have to be the default unit. That is, the csv uses t and btu while the mapping file assumes SI units kg and MJ. This also a problem for the economic flows which get converted to 2012 dollars through the mapping file. Initially I would propose that in WARMer we do the conversion of t -> kg and btu -> MJ (and also MTCO2E -> kg) before exporting
  • I would propose we overwrite the Method field and just replace it with WARM or WARMv15

@bl-young
Copy link
Collaborator

bl-young commented Sep 7, 2022

made the fixes above with 6d5b8d6
and added back MTCE ab09693

I think this should be done, but should do a final review of the ultimate method in https://github.com/USEPA/HIO/blob/main/lciafmt/create_WARM_LCIA.py

@bl-young bl-young closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants