Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to improve ghgi mappings #323

Merged

Conversation

bl-young
Copy link
Collaborator

  • Fixes overallocation of CO2 to buses (GHG-44)
  • Fixes missing allocation to gov't sectors for commercial emissions (see comment here), and therefore overallocation to all other sectors

@bl-young
Copy link
Collaborator Author

@WesIngwersen feel free to pull in, or wait depending on your workflow

modified_fba_allocation['HelperFlow'])
# merge is in the bea list to prevent dropped data,
# unless these bea codes already are in the helper dataframe, then skip
if not modified_fba_allocation['Sector'].isin(bea).any():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catherinebirney FYI flagging you since this is a change in what i suppose is a widely use function

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thanks meant to do that too - should be ok as I don't believe we use BEA as a helper allocation anywhere else (this chunk mostly protects FBS that allocate to BEA gov't codes and then have a helper allocation source like BLS). But Catherine should confirm

Copy link
Collaborator

@WesIngwersen WesIngwersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second look, the transportation allocation doesn't align perfectly with the NGIAM.
In the NGIAM, there is a lot more customization for certain fuel types of what they are allocated to.
the crosswalk has them more (but not perfectly) uniform right now.
For instance, jet fuel for gov sectors is exclusively allocated to Fed Defense in the NGIAM, but in the crosswalk its spread to all 92* sectors. That is just one example.

I would recommend closely alignment for m1 unless you think it should be handled differently.

@bl-young
Copy link
Collaborator Author

bl-young commented Feb 20, 2023

On second look, the transportation allocation doesn't align perfectly with the NGIAM. In the NGIAM, there is a lot more customization for certain fuel types of what they are allocated to. the crosswalk has them more (but not perfectly) uniform right now. For instance, jet fuel for gov sectors is exclusively allocated to Fed Defense in the NGIAM, but in the crosswalk its spread to all 92* sectors. That is just one example.

I would recommend closely alignment for m1 unless you think it should be handled differently.

I will look again. The original flow mapping of the fuel type Jet Fuel Transportation is a superset of the ultimate mapping, which also depends on the A-79 vehicle type. So for example military aircraft are only mapped to 928110. But that doesn't mean it was done correctly in all cases.

@WesIngwersen WesIngwersen merged commit f0c045d into refac_GHG_national_mecsallocationfix Feb 22, 2023
@bl-young bl-young deleted the refac_GHG_national_transport branch February 22, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants