-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to improve ghgi mappings #323
Fixes to improve ghgi mappings #323
Conversation
bl-young
commented
Feb 20, 2023
- Fixes overallocation of CO2 to buses (GHG-44)
- Fixes missing allocation to gov't sectors for commercial emissions (see comment here), and therefore overallocation to all other sectors
… different from NGHGIAM due to government sectors
@WesIngwersen feel free to pull in, or wait depending on your workflow |
modified_fba_allocation['HelperFlow']) | ||
# merge is in the bea list to prevent dropped data, | ||
# unless these bea codes already are in the helper dataframe, then skip | ||
if not modified_fba_allocation['Sector'].isin(bea).any(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@catherinebirney FYI flagging you since this is a change in what i suppose is a widely use function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thanks meant to do that too - should be ok as I don't believe we use BEA as a helper allocation anywhere else (this chunk mostly protects FBS that allocate to BEA gov't codes and then have a helper allocation source like BLS). But Catherine should confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second look, the transportation allocation doesn't align perfectly with the NGIAM.
In the NGIAM, there is a lot more customization for certain fuel types of what they are allocated to.
the crosswalk has them more (but not perfectly) uniform right now.
For instance, jet fuel for gov sectors is exclusively allocated to Fed Defense in the NGIAM, but in the crosswalk its spread to all 92* sectors. That is just one example.
I would recommend closely alignment for m1 unless you think it should be handled differently.
I will look again. The original flow mapping of the fuel type |
… set flowRatio to 0, then use sector aggregation to estimate dropped parent sectors
…getable totals and woody crops and cut christmas trees are not used in this activity set
…to refac_GHG_national_transport