Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference attributes need to be editable #431

Closed
rewolfe opened this issue Aug 18, 2016 · 4 comments
Closed

Reference attributes need to be editable #431

rewolfe opened this issue Aug 18, 2016 · 4 comments
Assignees
@lomky
Labels
an enhancement context Content Management context Front End priority high type technical
Milestone
Active Developmen...

Comments

@rewolfe
Copy link
Member

rewolfe commented Aug 18, 2016

It should be possible to edit attributes (bibliographic) entries in references using the GCIS user interface.
@amruelama amruelama mentioned this issue Aug 18, 2016
Closed
@lomky lomky removed their assignment Aug 22, 2016
@lomky lomky self-assigned this Sep 19, 2016
@lomky
Copy link
Collaborator

lomky commented Sep 20, 2016

After digging in, it appears that reference attributes are stored via hstore in the DB.

Two forward paths:

  1. Update the table to have the shared common traits broken out into their own fields, and the front those via standard routes to edit in stage
  2. Leave the hstore as is, and build in support at the DBI level for it. Beyond that, build the standard routes to edit in stage.

For the moment, Amrutha has access to the stage database which should solve the pressing need. Moving this to the backlog for now.

@lomky lomky removed their assignment Sep 20, 2016
@lomky lomky self-assigned this May 3, 2017
@lomky
Copy link
Collaborator

lomky commented May 3, 2017

@amruelama how does this look to you?

gcis

@amruelama
Copy link
Member

@lomky This looks good to me. But if you could move the delete buttons to the left side (or anywhere you think will be better), that would be great. Just don't want to accidentally delete the key as I enter the replace values.

lomky added a commit that referenced this issue May 4, 2017
@lomky
Making Ref Attributes Editable - Form updates
de0212e 
  - Moved reference attr display from relationship tab to primary tab
  - added delete buttons for each attribute
    - located on left based on user feedback
  - added replace value fields
  - added new attribute key/value entry

Currently non-functional.

Bumps #431
lomky added a commit that referenced this issue May 4, 2017
@lomky
Update form to direct properly
32a2696 
#Bumps #431
lomky added a commit that referenced this issue May 4, 2017
@lomky
Backend Reference Attr edit support
c751270 
 - Reference DB objects know how to update their attributes
 - Reference Controller knows how to call update
 - Reference DB objects know how to delete their attributes
 - Referene Controller knows how to call delete

Bumps #431
lomky added a commit that referenced this issue May 4, 2017
@lomky
Reference Attribute Edit handles edit without new.
06e0997 
  - Using smart match to catch (odd) cases where you get an updated
    attrs without the new key being present (like tests).

Bumps #431
lomky added a commit that referenced this issue May 4, 2017
@lomky
Added tests for reference attributes
f7525d3 
  - Tests add, update, and delete

Bumps #431
@lomky
Copy link
Collaborator

lomky commented May 4, 2017

Okay, this is ready to go!

lomky added a commit that referenced this issue May 8, 2017
@lomky
Consciously allow smartmatch for #431
1b7593b
@lomky lomky mentioned this issue May 9, 2017
Closed
@lomky lomky closed this as completed May 9, 2017
@amruelama amruelama mentioned this issue Jan 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomky lomky

Labels
an enhancement context Content Management context Front End priority high type technical
Projects
None yet
Milestone
Active Development for Next Release
Development

No branches or pull requests
3 participants
@lomky @rewolfe @amruelama