updated kingToMatrix to account for new KING --related output #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, update examples and tests with new argument.
smgogarten
approved these changes
May 6, 2019
|
Thanks for catching that case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function used to infer if it was --ibdseg or --kinship output from the column names present. However, with the --related option in KING now, that output contains both. The simplest solution is just to make the user specify which they want (they should know anyways), so I added a new 'estimator' argument.
I'm not 100% sure I did the match.arg() thing correctly, so if you could at least check that over, that would be good. Thanks!