Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ext usable factories #300

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Bugfix/ext usable factories #300

merged 4 commits into from
Feb 17, 2023

Conversation

jmcarson
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #300 (41458ac) into main (c40f451) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         104      104           
  Lines       19772    19773    +1     
=======================================
+ Hits        19731    19732    +1     
  Misses         41       41           
Impacted Files Coverage Δ
anvil_consortium_manager/tests/factories.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmcarson
Copy link
Collaborator Author

Main change here is super minor: use get_user_model in the acm test factories so they can be used by the other django sites. Had to make a few other changes to get it to locally run tests successfully. Just running it by you in case you have concerns.

Copy link
Contributor

@amstilp amstilp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jmcarson jmcarson merged commit 7a4d5d1 into main Feb 17, 2023
@amstilp amstilp deleted the bugfix/ext-usable-factories branch March 23, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants