Feature/workspace autocomplete by type #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new autocomplete view and url for autocompleting workspace names by type. Add an adapter method to the BaseWorkspaceAdapter that can be overridden by custom workspace adapters defined by the user. Add tests. Note that some of the tests are breaking, I think because the test workspace adapter remains registered after some other test?
A couple tests in WorkspaceDeleteTest class registered a new adapter, but the tearDown method did not reset the registry. This caused later tests to break.
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
========================================
Coverage 99.79% 99.80%
========================================
Files 112 112
Lines 20466 20566 +100
========================================
+ Hits 20425 20525 +100
Misses 41 41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseWorkspaceAdapter.get_autocomplete_queryset()that can be overridden by projects defining custom database types.Closes #291