Correctly import groups when the service account is both a member and an admin #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that this bug occurs when the service account running the app is both a member and an admin of the same group. Update the ManagedGroup.anvil_import method to handle multipler ecords being returned from the API for a given group.
Add tests confirming the ManagedGroup.anvil_audit behavior is correct when the response contains two records for the same group, one as an admin and one as a member.
If any of the records returned by the app indicates that the service account is an admin, then set is_managed_by_app=True. Closes #360
The email was being set by the last group in the json response, which is not necessarily the group being imported. Fix the email by setting it in the new for loop instead of at the end, when the for loop has finished.
amstilp
changed the title
Codecov Report
@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 117 117
Lines 20547 20614 +67
=======================================
+ Hits 20508 20575 +67
Misses 39 39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: set is_managed_by_app correctly when importing a group where the app service account is both a member an an admin.