Fix AnVIL audit when service account is not directly a group admin #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug occurs when the app is not directly listed as an admin, but is an admin of a group via being in another group (which is an admin of the first group).
Add a try/except statement that removes the service account from the list of ManagedGroup admins returned by AnVIL. This fixes the bug where the managed group audit fails when the service account is not directly an admin of the group.
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 117 117
Lines 20614 20630 +16
=======================================
+ Hits 20575 20591 +16
Misses 39 39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the AnVIL membership audit for a ManagedGroup when the service account running the app is not directly an admin of the group (for example, when another group is an admin and the service account is a member of the other group).
Closes #362