Fix not in app table in audit report emails #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NotInApp table in the audit report emails just showed dashes for all records that aren't in the app. This happened because the export results for "not_in_app" are a list of strings, not a dictionary as expected by django-tables2. Modify this by adding a render_instance method to the table, which just returns the string. Closes #367
Codecov Report
@@ Coverage Diff @@
## main #368 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 117 117
Lines 20630 20662 +32
=======================================
+ Hits 20591 20623 +32
Misses 39 39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NotInApp table in the audit report emails just showed dashes for all records that aren't in the app. This happened because the export results for "not_in_app" are a list of strings, not a dictionary as expected by django-tables2. Modify this by adding a render_instance method to the table, which just returns the string.
Closes #367