Fix for sunrise/sunset north/south of the polar circles #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 28, 2020 15:40
…x_hour routine, thus, allowing latitudes north/south of the polar circles.
…attributes. Fix to transform input parameters expected as float to floats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for sunrise/sunset north/south of the polar circles in set_min_max_hour routine. This will allow (and prevent abortion) to simulate MetSim for latitudes north/south of the polar circles.
So far, values of (in set_min_max_hour) greater or smaller zero get eliminated. This results in numpy arrays of lesser dimensions (i.e. less than 365 days) as required in subsequent computation.
This circumstance got fixed by setting radiation to zero for days without sunrise or its maximum value for days without sunset.