New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix initialization of coupler fields #716

Merged
merged 12 commits into from Jul 12, 2017

Conversation

Projects
None yet
2 participants
@dgergel
Contributor

dgergel commented Jun 7, 2017

  • closes #xxx
  • tests passed
  • new tests added
  • science test figures
  • ran uncrustify prior to final commit
  • ReleaseNotes entry

This PR does the following:

  • sets the temperature field in the l2x_data_struct (l2x_Sl_t) during initialization using avg_temp from the soil_con_struct, which is equivalent to using the temperature of the top soil layer, since this is the value we use to initialize soil temperatures from a cold start

  • sets the upwelling longwave field in the l2x_data_struct (l2x_Fall_lwup) using l2x_Sl_t and emissivity from the param struct

@dgergel dgergel requested review from jhamman and bartnijssen Jun 7, 2017

@dgergel dgergel self-assigned this Jun 7, 2017

@dgergel dgergel added the CESM driver label Jun 7, 2017

@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Jun 7, 2017

Contributor

Note: we may want to combine vic_initialize_albedo, vic_initialize_temperature and vic_initialize_lwup into one function.

Contributor

dgergel commented Jun 7, 2017

Note: we may want to combine vic_initialize_albedo, vic_initialize_temperature and vic_initialize_lwup into one function.

Show outdated Hide outdated vic/drivers/cesm/include/vic_driver_cesm.h Outdated
Show outdated Hide outdated vic/drivers/cesm/src/vic_cesm_init_library.c Outdated

@jhamman jhamman merged commit ec96d1f into UW-Hydro:develop Jul 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment