LTI Redirection #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmsibley
commented
Mar 14, 2017
|
|
||
| logger.trace(new String(b)); | ||
|
|
||
| if (303 == status) { |
There was a problem hiding this comment.
magic number. This possibly should be opened up as well to the 300-series, but right now I know that the service returns a 303 on success.
apetro
approved these changes
Mar 16, 2017
|
|
||
| /** | ||
| * | ||
| * @author sibley |
There was a problem hiding this comment.
I don't favor @author annotations in shared-ownership codebases, but I recognize it's a matter of style and reasonable developers can differ on this point.
There was a problem hiding this comment.
I don't care for it either. I've since edited the new file templates to omit this and license information.
| @RequestMapping(value="/go/{key}", method=RequestMethod.GET) | ||
| public void proxyRedirect(HttpServletRequest request, HttpServletResponse response, @PathVariable String key) throws | ||
| ClientProtocolException, IOException, LtiSigningException, URISyntaxException { | ||
| int statusCode = HttpServletResponse.SC_BAD_REQUEST; |
There was a problem hiding this comment.
Suggest inline HttpServletResponse.SC_BAD_REQUEST the one place it's used in this method.
| if (null != uri) { | ||
| response.sendRedirect(uri.toString()); | ||
| } else { | ||
| response.sendError(statusCode, "Could not build redirect URI!"); |
There was a problem hiding this comment.
Suggest including {key} in error response.
vertein
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is broken, I'm just opening a pull request to start a code reviewI refactored a bit of the existing code and started writing a redirector.
The refactors were pulling HttpServletRequest from the Service scope, and pulling some common prep logic out to be used by the redirector. These should make unit testing the Service methods easier (though I haven't written any yet 🤷♂️)
The redirector is using the Spring Web's built in RestTemplate to hit the remote url. I opted to go with that over HttpComponents just to learn something new and to not pull in a dependency if I didn't need to. However, as it's written now, I'm getting a 501 back from the external service, so I may pull in HttpComponents just for the extra debugging information I know I can get out of it.I looked at the rssToJson microservice and swapped in HttpComponents per that. Everything's a whole lot simpler. Locally I'm getting a 400 from the external service, but that's probably because I don't have true authentication set up. The real test of this will be out on predev.