Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes: 1. Interpolation of missing data, 2. Spelling error: CLI file #56

Merged
merged 3 commits into from
Jun 24, 2023

Conversation

SarathUW
Copy link
Collaborator

No description provided.

@@ -98,16 +98,20 @@ def _read(self):
self.winds[day, :, :] = wind
# pbar.update(1)

def _impute_basin_missing_data(self, combined_data):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add self as an argument

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added argument 'self'

Copy link
Member

@SanchitMinocha SanchitMinocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor change request.

Copy link
Member

@SanchitMinocha SanchitMinocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Thanks for fixing the bugs!

@SanchitMinocha SanchitMinocha merged commit e6e5d11 into UW-SASWE:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants