New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forecasting Plugin #90

Merged

SanchitMinocha merged 19 commits into main from forecasting

Feb 13, 2024

Member

pritamd47 commented Feb 10, 2024

Adding a plugin for short term forecasting of inflow, storage change and outflow.

pritamd47 added 11 commits

December 20, 2023 12:46


          forecasting run metsim

93ef076


          forecasting using vic

f021000


          routing for forecasting

94bda1b


          forecast inflow files

1e1efb6


          forecasting plugin

47354a0


          remove combined nc

a5ef0ec


          download archival data

e8037f2


          add documentation for forecasting

0c706ad


          update rat basin and run rat

cb8f5bc


          cleanup before running plugin

8936d76


          forecast evaporation using either a single nominal value of surface a…

fe15fc0

…rea or time series

pritamd47 requested a review from SanchitMinocha

February 10, 2024 00:05

SanchitMinocha reviewed

View reviewed changes

docs/Plugins/Forecasting.md Outdated Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/rat_basin.py Outdated Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/core/run_routing.py Outdated Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/data_processing/metsim_input_processing.py Outdated Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/data_processing/metsim_input_processing.py Outdated Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/rat_basin.py Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/run_rat.py Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/run_rat.py Outdated Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/run_rat.py Outdated Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/plugins/forecasting.py Outdated Show resolved Hide resolved

SanchitMinocha requested changes

View reviewed changes

Member

SanchitMinocha left a comment •

edited

Loading

Great work. Good to see so much done within a month or so. Have left a few minor comments.
I am glad that first plugin is going to be officially part of RAT and not only that, ResORR will also be added soon as a plugin.

pritamd47 added 7 commits

February 12, 2024 23:25


          resolve pr review comments, add paper data

04a59d8


          change from BASIN to PLUGINS

2b602d9


          rearranged comment

c24f138


          added to multiple basin run

bec83f6


          forecast output glob pattern update

f23edad


          removed temporary debug statements

98f9dd5


          added a few comments for readibility + defining where RAT step 1 and …

c566772

…2 are running

Member Author

pritamd47 commented Feb 13, 2024

Thanks for the review @SanchitMinocha! I have updated the code + docs after addressing the requested changed, please have a look when you get a chance.

pritamd47 requested a review from SanchitMinocha

February 13, 2024 08:26

SanchitMinocha reviewed

View reviewed changes

src/rat/run_rat.py Outdated Show resolved Hide resolved

SanchitMinocha reviewed

View reviewed changes

src/rat/run_rat.py Outdated Show resolved Hide resolved

SanchitMinocha requested changes

View reviewed changes

Member

SanchitMinocha left a comment •

edited

Loading

Looks good. There are minor corrections in run_rat.py. Also, can you please make sure that rat test for Nueces/Gunnison is running. That will ensure that its existing functionality will be fine at least. Rest all is looking pretty good to me.


          update run rat

4a612e6

SanchitMinocha approved these changes

View reviewed changes

Member

SanchitMinocha left a comment •

edited

Loading

Looks good. Thanks for doing it.

SanchitMinocha merged commit 71f81c6 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet