This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow has been CSRF vulnerable since forever ago 😄
Here's an example CSRF attack that when loaded in a user's browser while they're logged into flow will add the Security course to their shortlist.
Test Plan
Loaded the above POC exploit before this patch, saw that it added the security course.
Applied patch, deleted account using
tools/devshell.py
, recreated account, ensured that I was still able to import transcript and add ratings to courses.Loaded the above POC again, saw that it hit a 403 by looking at the network panel in the chrome devtools.