-
Notifications
You must be signed in to change notification settings - Fork 73
Conversation
As mentioned in #66, the tests rely on chromedriver being in the path - could you add it to the setup script and test it in the VM? May want to use https://gist.github.com/mikesmullin/2636776 as a starting point, but I think we want to grab http://chromedriver.storage.googleapis.com/2.9/chromedriver_linux64.zip instead of the zip listed in that gist. |
For the mongo issue, should we Also, I think the first years mentioned that running Also, were you able to test up to |
Also, did your Ubuntu install came with a bunch of |
@phleet Added chromedriver, but couldn't test it properly in my headless VM. @divad12 |
Would you mind trying to run this whole thing from scratch and see if can complete installation and bootup? I'm especially curious about the |
I ran the whole thing from scratch after each set of changes to ensure everything worked. I'll rebase onto |
Sweet! Would it be easy to test on another distro? If not, that's totally fine, let's get this in first. (I just recall Gabriel ran into problems like having to download |
Since we use Do you know what distro and version Gabriel was running? |
Not sure (but it was Debian-based). Let's point him to this PR after we open-source. |
Tested again, and |
Awesome. LGTM. |
I also just ran into the problem where mongo took too long to start and caused Flask to crash. I ran The only things I did were
I suppose we could monitor one of mongo's log files and start Flask only after we know mongo has started. Or we could just sleep a few seconds after starting mongod. I'm leaning towards the latter. What do you think @divad12? |
So, I believe this is only an issue with starting up Mongo with our config for the first time on Linux. Since this is only a one-time issue, I'd rather not sleep a few seconds in I know, really gross hack too, but at least it won't affect each run of |
I don't know how to repro this issue and, although it looks like it's fine after we "warm up" mongo, I don't know for sure. If it's consistently (and randomly) an issue, we could perform the sleep only when we're on Linux. I agree with your approach and will implement that for now. |
@jswu Easiest way to repro is probably re-provision your vagrant image to its initial state that does not have mongo or anything else installed. |
Oh sorry, I just saw that you wrote "I've previously run through this scenario several times (without part 3), but haven't run into this until now." Derp, can't read. |
I'll merged this for now, and deal with mongo in a separate PR later (since Linux setup is completely broken without this PR) |
Tested on a fresh install of Ubuntu 12.04 inside a Vagrant vm (VirtualBox). Only remaining issue is that
mongod
seems to start up automatically after install or something, which binds to the address that we need.Killing the
mongod
process and then runningmake local
works just fine.