Fix Typescript Arrow Consts needing using the filename #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jrwpatterson ! We'll review and update. |
vados-xenon
requested changes
Oct 29, 2020
...li/src/steps/serialization/component/implementation/typescript/component/getComponentName.ts
Outdated
Show resolved
Hide resolved
...li/src/steps/serialization/component/implementation/typescript/component/getComponentName.ts
Outdated
Show resolved
Hide resolved
...li/src/steps/serialization/component/implementation/typescript/component/getComponentName.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Victor Adossi <61000371+vados-xenon@users.noreply.github.com>
|
@vados-xenon I have accepted your comments thank you |
vados-xenon
approved these changes
Oct 29, 2020
matthewchigira
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Thank you very much for your PR @jrwpatterson
Looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the fact that the latest release of Arrow names needs the filenames to be in ProperCase because the arrow-function implementation is a child of the actual component. This means that in getComponentName it was falling back to the filename and dumping components such as
import simple-select from '../src/components/simple-select.tsxin the components.js file in the .uxpin-mergeI don't think it will affect any other way of importing when using typescript.