-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nicolasbrugneaux/react celo #677
Nicolasbrugneaux/react celo #677
Conversation
@nicolasbrugneaux is attempting to deploy a commit to the Ubeswap Team on Vercel. A member of the Team first needs to authorize it. |
This also seems to resolve this issue: |
Possible to take a look at the failing tests? |
9eac5fd should be fixing the issue mentionned in WalletConnect/walletconnect-monorepo#1749 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@nicolasbrugneaux lint/tsc are still broken. Can you take another look? |
Fixed the issues in 5d1886f |
Well I guess warnings are forbidden, so I fixed these too |
(for future reference) The two repos have different code structures so this WalletConnect v2 PR doesn’t translate 1:1. |
Taking over the PR from @silasbw (thank you for the initial PR in April, I kept your commits).
This upgrades react-celo to v5 which supports WalletConnect (WC) v2 but not WC v1. WC v1 will shutdown the 28th of June 2023, so this will need to be tested and merged before then.