Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicolasbrugneaux/react celo #677

Merged
merged 8 commits into from
Jun 28, 2023

Conversation

nicolasbrugneaux
Copy link

Taking over the PR from @silasbw (thank you for the initial PR in April, I kept your commits).

This upgrades react-celo to v5 which supports WalletConnect (WC) v2 but not WC v1. WC v1 will shutdown the 28th of June 2023, so this will need to be tested and merged before then.

@vercel
Copy link

vercel bot commented Jun 21, 2023

@nicolasbrugneaux is attempting to deploy a commit to the Ubeswap Team on Vercel.

A member of the Team first needs to authorize it.

@nicolasbrugneaux
Copy link
Author

This also seems to resolve this issue:

@BriungRi
Copy link

Possible to take a look at the failing tests?

@nicolasbrugneaux
Copy link
Author

9eac5fd should be fixing the issue mentionned in WalletConnect/walletconnect-monorepo#1749

@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ubeswap-interface 🔄 Building (Inspect) Jun 27, 2023 7:13pm

@BriungRi
Copy link

@nicolasbrugneaux lint/tsc are still broken. Can you take another look?

@nicolasbrugneaux
Copy link
Author

@nicolasbrugneaux lint/tsc are still broken. Can you take another look?

Fixed the issues in 5d1886f

@nicolasbrugneaux
Copy link
Author

Well I guess warnings are forbidden, so I fixed these too

@BriungRi BriungRi merged commit bf82379 into Ubeswap:main Jun 28, 2023
@nicolasbrugneaux nicolasbrugneaux deleted the nicolasbrugneaux/react-celo branch June 29, 2023 06:18
@arthurgousset
Copy link

(for future reference)
Noting that the Ubeswap team flagged that ubeswap-interface is not the code base powering the app.ubeswap.org UI. Instead it's the ubeswap-aio repo.

The two repos have different code structures so this WalletConnect v2 PR doesn’t translate 1:1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants