feat: support for emptyVal in template.json #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: add PAGE_TYPE_FOR_THRESHOLD to config; which picks GLOBAL_PAGE_THRESHOLD_WHITE/BLACK from constants fix: populate empty responses using a set; compress image
Udayraj123
force-pushed
the
feature/61
branch
from
9d40f17
to
b206728
Compare
deepakgouda
reviewed
Oct 11, 2022
src/constants.py
Outdated
| @@ -14,8 +14,7 @@ | |||
| CURRENT_MODULE_DIR = os.path.dirname(__file__) | |||
| CONFIG_DEFAULTS_PATH = os.path.join(CURRENT_MODULE_DIR, "defaults/config.json") | |||
| SCHEMA_DEFAULTS_PATH = os.path.join(CURRENT_MODULE_DIR, "defaults/schema.json") | |||
| TEMPLATE_DEFAULTS_PATH = os.path.join( | |||
| CURRENT_MODULE_DIR, "defaults/template.json") | |||
| TEMPLATE_DEFAULTS_PATH = os.path.join(CURRENT_MODULE_DIR, "defaults/template.json") | |||
There was a problem hiding this comment.
Would os.path.join(CURRENT_MODULE_DIR, "defaults","template.json") make more sense, eradicating the OS dependency? Windows machines would expect \ if I'm correct.
deepakgouda
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61
Changes
Additional changes