Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional changes to enable rule ban in future images #10

Merged
merged 3 commits into from
Jun 29, 2017

Conversation

myroslavarm
Copy link
Collaborator

No description provided.

@@ -0,0 +1,4 @@
accessing
enabledSettingID
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method is not used

@@ -12,7 +12,8 @@ ruleToggleSettingsOn: aBuilder
thenDo: [ :rule |
| inst |
inst := rule new.
(aBuilder setting: #enabled)
(aBuilder setting: rule settingID)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now settingID is not defined

Copy link
Owner

@Uko Uko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Uko Uko merged commit 9ef3c0e into Uko:development Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants