split variant into variant and optional #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UkoeHB
approved these changes
Feb 16, 2024
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Feb 17, 2024
UkoeHB
pushed a commit
that referenced
this pull request
Mar 6, 2024
UkoeHB
pushed a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets us reap the benefit of "optional variants" when we want to have the ability to not have a value with the
optional_variant, but also we don't have to deal with null cases when we don't want to (which is almost all cases). Null cases are particularly annoying when it comes to dealing with serialization and de serialization. It also makes writing rigid types harder and messier.