Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-write of Time Lapse #18923

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Re-write of Time Lapse #18923

wants to merge 4 commits into from

Conversation

GregValiant
Copy link
Collaborator

@GregValiant GregValiant commented Apr 20, 2024 •
edited

An update to the Time Lapse script.

  • Added "insertion frequency" so the user can decide how often to take an image.
  • Added support for relative extrusion.
  • Retract is now a boolean and the settings come from Cura. There won't be a retraction if there is already a retraction.

Description

Type of change

  • [ X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Test Configuration:

  • Operating System: Windows 10 Pro (Intel processor)
  • Cura 4.13.1 and Cura 5.7.0

Checklist:

  • [ X] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • [ X] I have read the Contribution guide
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have uploaded any files required to test this change

@GregValiant
Re-write Time Lapse
0ba72bc 
An update to the script.
- Added insertion frequency
- Added support for relative extrusion
- Retract is now a boolean and the settings come from Cura.  There won't be a retraction if there is already a retraction.
@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Apr 20, 2024
@GregValiant GregValiant changed the title Re-write Time Lapse Re-write of Time Lapse Apr 21, 2024
@casperlamboo
Copy link
Contributor

hi @GregValiant, I'm not on the cura team anymore. best to request a review of one of the other cura devs. Thanks

@GregValiant
Copy link
Collaborator Author

@casperlamboo thanks for getting back.

I hope all goes well for you in the next phase.

Greg

@GregValiant GregValiant requested review from saumyaj3 and Vandresc and removed request for casperlamboo April 22, 2024 10:48
@jellespijker
Copy link
Member

@wawanbreton could you take look at this next power hours, since @saumyaj3 is currently on holiday

@GregValiant
Copy link
Collaborator Author

@wawanbreton The last commit adds support for firmware retraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saumyaj3 saumyaj3 Awaiting requested review from saumyaj3

@Vandresc Vandresc Awaiting requested review from Vandresc

Assignees
No one assigned
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GregValiant @casperlamboo @jellespijker