Cura-specific settings in xmlmaterials #2333

fieldOfView · 2017-08-29T06:32:31Z

This PR adds functionality to include any Cura setting in an xml fdm material file. These Cura-specific settings are namespaced to not conflict with the fdm material xml spec.

A followup to this PR could enable the user to add settings to the material profile on the materials pane of the preferences. This UI is not part of this PR.

A material with a namespaced cura setting would look like this (note the namespace declaration at the top, and the <cura.setting> tag:

<?xml version="1.0" encoding="UTF-8"?>
<fdmmaterial xmlns="http://www.ultimaker.com/material" xmlns:cura="http://www.ultimaker.com/cura" version="1.3">
    <metadata>
        <name>
            <brand>Test</brand>
            <material>PLA</material>
            <color>Test Color</color>
        </name>
        <GUID>30a578af-5661-4149-8fbf-c82d8153a697</GUID>
        <version>1</version>
        <color_code>#ffc924</color_code>
        <description></description>
        <adhesion_info></adhesion_info>
    </metadata>
    <properties>
        <density>1.24</density>
        <diameter>2.85</diameter>
    </properties>
    <settings>
        <setting key="print temperature">200</setting>
        <setting key="heated bed temperature">60</setting>
        <setting key="standby temperature">175</setting>

        <cura:setting key="infill_sparse_density">13</cura:setting>

        <machine>
            <machine_identifier manufacturer="Ultimaker B.V." product="Ultimaker 2+"/>
            <machine_identifier manufacturer="Ultimaker B.V." product="Ultimaker 2 Extended+"/>

            <hotend id="0.25 mm" />
            <hotend id="0.4 mm" />
            <hotend id="0.6 mm" />
            <hotend id="0.8 mm" />
        </machine>

        <machine>
            <machine_identifier manufacturer="Ultimaker B.V." product="Ultimaker 2"/>
            <machine_identifier manufacturer="Ultimaker B.V." product="Ultimaker 2 Go"/>
            <machine_identifier manufacturer="Ultimaker B.V." product="Ultimaker 2 Extended"/>
            <setting key="standby temperature">150</setting>
            <setting key="processing temperature graph">
                <point flow="2" temperature="180"/>
                <point flow="10" temperature="230"/>
            </setting>
        </machine>

        <machine>
            <machine_identifier manufacturer="Ultimaker B.V." product="Ultimaker Original"/>
            <setting key="standby temperature">150</setting>
            <cura:setting key="infill_sparse_density">14</cura:setting>
        </machine>

        <machine>
            <machine_identifier manufacturer="Ultimaker B.V." product="Ultimaker 3"/>
            <machine_identifier manufacturer="Ultimaker B.V." product="Ultimaker 3 Extended"/>
            <setting key="print cooling">100</setting>
            <hotend id="BB 0.4" />
            <hotend id="BB 0.8" />
            <hotend id="AA 0.25">
                <setting key="hardware compatible">yes</setting>
            </hotend>
            <hotend id="AA 0.4">
                <setting key="hardware compatible">yes</setting>
            </hotend>
            <hotend id="AA 0.8">
                <setting key="hardware compatible">yes</setting>
            </hotend>
        </machine>

    </settings>
</fdmmaterial>

nallath · 2017-08-29T07:24:51Z

CURA-4253

maukcc · 2017-09-05T08:25:53Z

Please make it so that it can be added under the machine specific details also, and not only as a general setting

fieldOfView · 2017-09-05T09:12:06Z

@maukcc, that should already work. Doesn't it?

maukcc · 2017-09-05T09:18:08Z

I do not know, I have not tested it.
I was just looking at the example, and saw it being used in the general settings.

fieldOfView · 2017-09-19T11:42:28Z

Out of curiosity, is CURA-4253 in this sprint or in a future sprint?

In other words: bump

nallath · 2017-09-19T12:28:24Z

Yeah it's in there, but it's a bit of a mess as to if it's something that we should add. The whole material profiles are a bit of a mess.

fieldOfView · 2017-09-19T13:12:29Z

The whole material profiles are a bit of a mess.

And this could be a first step towards making it more consistent with the rest of the profiles system. Unless you want to drop the xml profiles all the way.

maukcc · 2017-09-19T13:52:52Z

+1 for dropping them.

nallath · 2017-09-19T14:54:58Z

Well, we're not going to drop them all together as far as I know. I will try to get some concensus regarding this. The current implementation of Cura is bloated. A lot of the slowness in Cura is caused by the current material system.

Ghostkeeper · 2017-09-24T15:19:33Z

I don't see us dropping the XML format any time soon. There's lots of plans for the near future for the material files. It's not going to become simpler either...

I see this sort of change as the only real solution that would make everybody happy, but some people see this as pollution of the files so apparently it doesn't.

fieldOfView · 2017-11-14T10:33:51Z

Does it make sense if I keep this PR updated? If it stands no chance of being merged anyway, I would rather just close the PR.

ChrisTerBeke · 2017-11-14T10:34:50Z

There is still a discussion about whether this should be supported. XML spec clearly states that it's extendable thus this could be added, but not everyone agrees...

fieldOfView · 2017-11-14T11:41:50Z

Ok, I'll fix the conflict then...

# Conflicts: # plugins/XmlMaterialProfile/XmlMaterialProfile.py

fieldOfView · 2017-11-23T14:05:30Z

For reference: #1141 (comment)

Ghostkeeper · 2017-11-28T23:13:57Z

It's about to get a conflict with #2867 as well. You might want to leave it for a while.

I think it's best to just plan a meeting in person with a few firmware guys about this. I'm sure @daid or @MarcoTvM has a good opinion too.

ChrisTerBeke · 2017-12-04T08:59:30Z

I just did a quick unit test and the firmware breaks when adding Cura specific settings to an XML file. This means that we can't add this functionality until the firmware supports it.

fieldOfView · 2017-12-04T09:13:23Z

So the firmware has an XML parser that does not understand namespaces? That's strange...

nallath · 2017-12-05T08:24:43Z

Woah. That's weird...

daid · 2017-12-05T08:30:13Z

Surprising, the code was written to ignore anything unknown. What exception is it throwing? (Element-tree xml is a bit annoying to use with namespaces)

# Conflicts: # plugins/XmlMaterialProfile/XmlMaterialProfile.py

fieldOfView · 2017-12-18T11:52:27Z

Fixed conflicts with master

# Conflicts: # plugins/XmlMaterialProfile/XmlMaterialProfile.py

fieldOfView · 2018-03-06T10:41:27Z

Fixed conflicts with master

Appesteijn · 2018-03-14T08:46:03Z

To be clear, we need changes in the firmware for this PR and that is not likely to happen in the upcoming 4-6 months.

fieldOfView · 2018-03-14T09:05:41Z

@Appesteijn, understood. I've set a reminder for a birthday party on august 29. There will be cake.

Ghostkeeper · 2018-03-21T08:19:07Z

@Appesteijn Robin and I tested this a month ago in preparation for the model assistant issue. The firmware accepts this since version 4.0 apparently. So it's long been in there.

ianpaschal · 2018-03-21T15:08:51Z

Ok. I've been testing this. Number values seem to work like gravy but boolean (yes/no) values don't seem to have any effect. I've tried a few to try and make sure that it's not that they're being overwritten somehow but no luck.

Have you gotten this to work, @fieldOfView?

fieldOfView · 2018-03-21T20:59:49Z

I had not tested anything but numeric values, but adding a bool setting works for me. I added the following line to generic_pla, and it successfully turned off retraction for the materials.

<cura:setting key="retraction_enable">False</cura:setting>

fieldOfView · 2018-03-21T21:04:43Z

Godmode plugin is a good way to inspect if the internal material profiles get created in the way you expect:
https://github.com/sedwards2009/cura-god-mode-plugin

ianpaschal · 2018-03-22T13:15:49Z

I had not tested anything but numeric values, but adding a bool setting works for me. I added the following line to generic_pla, and it successfully turned off retraction for the materials.

<cura:setting key="retraction_enable">False</cura:setting>

Not here unfortunately. Also, regardless, this should implement the same same boolean syntax as existing attributes which is yes/no

fieldOfView · 2018-03-22T15:57:13Z

I have fixed reading and writing yes/no as boolean values. True/False still work for reading, but they are always written as yes/no.

If this still does not work, please check with GodMode plugin if the value gets overwritten by another profile higher up the stack.

ianpaschal · 2018-03-23T08:39:51Z

Yeah I was using GodMode. I've tested again it seems to work. I'm not sure why I was having troubles yesterday.

ianpaschal · 2018-03-23T08:41:37Z

cura/CuraApplication.py

+
+            # Use the previously found center of the group bounding box as the new location of the group
+            group_node.setPosition(group_node.getBoundingBox().center)
+


These changes don't seem to be related to material loading, but maybe I'm missing something. Can you explain why they're in the PR?

ianpaschal · 2018-03-23T08:43:35Z

I think there's several files in this branch which need to have master pulled in.

fieldOfView · 2018-03-23T13:56:31Z

Something went wrong merging in master. Just a minute...

fieldOfView · 2018-03-23T13:58:41Z

Fixed the merge/master issue.

ianpaschal · 2018-03-23T18:51:57Z

Great! In this case, merging!

fieldOfView · 2018-03-23T19:43:28Z

@Appestein, scrap that cake in august. The birthdayparty is off... I’m having a beer instead now.

Appesteijn · 2018-03-23T20:11:25Z

Nooooo, @ianpaschal what did you do!!!! 😄

filipgoc · 2018-04-16T16:45:33Z

Loving this! Is this gonna make it into Cura 3.3 ?!

fieldOfView · 2018-04-16T17:45:28Z

It’s in. Note that there is no UI for it whatsoever, but you can edit values into the xml files now

filipgoc · 2018-04-16T17:55:15Z

Nice! This is a major improvement that I've not even hoped for anymore!

Now I can finally create functional material profiles (and not a strange conglomeration of materials and quality with hopes it falls in place.)

PS: don't care about GUI crazy much even though it will be nice one of these days. More than happy to fire up the notepad.

fieldOfView added 2 commits August 12, 2017 16:03

Add support for deserialising namespaced Cura settings in XML materials

e163871

Add support for serialising namespaced Cura settings in XML materials

0f8a57e

Merge branch 'master' into feature_xmlmaterials_cura_settings

185c283

# Conflicts: # plugins/XmlMaterialProfile/XmlMaterialProfile.py

fieldOfView mentioned this pull request Nov 27, 2017

Speed overrides in materials #1141

Closed

ChrisTerBeke added the JIRA label Dec 1, 2017

fieldOfView added 2 commits December 18, 2017 12:47

Merge branch 'master' into feature_xmlmaterials_cura_settings

266be74

# Conflicts: # plugins/XmlMaterialProfile/XmlMaterialProfile.py

Fix merge error

a65edda

ChrisTerBeke removed the JIRA label Jan 22, 2018

fieldOfView mentioned this pull request Feb 28, 2018

[Extrusion Multiplier] Add this parameter in the 'Material' panel, due to it is strictly related to the filament brand/material/etc. you are using #3372

Open

Merge branch 'master' into feature_xmlmaterials_cura_settings

0578e74

# Conflicts: # plugins/XmlMaterialProfile/XmlMaterialProfile.py

Merge branch 'master' into feature_xmlmaterials_cura_settings

a85c42c

Fix reading and writing yes/no as boolean values

e7ca4f3

ianpaschal reviewed Mar 23, 2018

View reviewed changes

Ghostkeeper mentioned this pull request Mar 23, 2018

should material presets override quality (general) presets? (/ or a bug report) #1135

Closed

Merge branch 'master' into feature_xmlmaterials_cura_settings

251e24f

ianpaschal merged commit 76b837e into Ultimaker:master Mar 23, 2018

diegopradogesto mentioned this pull request Jun 20, 2018

Per-filament first-layer hotend/print temperature #3957

Closed

fieldOfView deleted the feature_xmlmaterials_cura_settings branch October 5, 2018 14:11

filipgoc mentioned this pull request Jan 23, 2019

[3.3.1] Flow Setting in Material Profile #3946

Closed


		# Use the previously found center of the group bounding box as the new location of the group
		group_node.setPosition(group_node.getBoundingBox().center)

Cura-specific settings in xmlmaterials #2333

Cura-specific settings in xmlmaterials #2333

Conversation

fieldOfView commented Aug 29, 2017

nallath commented Aug 29, 2017

maukcc commented Sep 5, 2017

fieldOfView commented Sep 5, 2017

maukcc commented Sep 5, 2017

fieldOfView commented Sep 19, 2017

nallath commented Sep 19, 2017

fieldOfView commented Sep 19, 2017

maukcc commented Sep 19, 2017

nallath commented Sep 19, 2017

Ghostkeeper commented Sep 24, 2017

fieldOfView commented Nov 14, 2017

ChrisTerBeke commented Nov 14, 2017

fieldOfView commented Nov 14, 2017

fieldOfView commented Nov 23, 2017

Ghostkeeper commented Nov 28, 2017

ChrisTerBeke commented Dec 4, 2017

fieldOfView commented Dec 4, 2017

nallath commented Dec 5, 2017

daid commented Dec 5, 2017

fieldOfView commented Dec 18, 2017

fieldOfView commented Mar 6, 2018

Appesteijn commented Mar 14, 2018

fieldOfView commented Mar 14, 2018

Ghostkeeper commented Mar 21, 2018

ianpaschal commented Mar 21, 2018

fieldOfView commented Mar 21, 2018 • edited Loading

fieldOfView commented Mar 21, 2018

ianpaschal commented Mar 22, 2018

fieldOfView commented Mar 22, 2018

ianpaschal commented Mar 23, 2018

ianpaschal Mar 23, 2018

Choose a reason for hiding this comment

ianpaschal commented Mar 23, 2018

fieldOfView commented Mar 23, 2018

fieldOfView commented Mar 23, 2018

ianpaschal commented Mar 23, 2018

fieldOfView commented Mar 23, 2018

Appesteijn commented Mar 23, 2018 • edited Loading

filipgoc commented Apr 16, 2018

fieldOfView commented Apr 16, 2018

filipgoc commented Apr 16, 2018 • edited Loading

fieldOfView commented Mar 21, 2018 •

edited

Loading

Appesteijn commented Mar 23, 2018 •

edited

Loading

filipgoc commented Apr 16, 2018 •

edited

Loading