Add closing operation on inner walls. #1252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent rounding errors from merging holes with each other too early. We might want to skip this and just wait until we get libArachne properly merged, which will _also_ solve this problem. CURA-7424
|
I don't really know if this would be a good solution. I think you had the same feeling. My first instinct is that this could break things by accidentally fusing walls together. However if I think hard about it I can't think of a case where you wouldn't want that to happen. |
|
After discussion with the team, we've decided to close this PR in favour of #1210 . This could erase very small holes in the model, although they would still be fused together by virtue of being so close together. In general, all developers had a bad feeling about this although we couldn't logically give a counterexample of why this PR is bad. We think #1210 is likely a more reliable way to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent rounding errors from merging holes with each other too early. We might want to skip this and just wait until we get libArachne properly merged, which will also solve this problem.
CURA-7424