Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum volumetric flow rate, with fixes #1828

Closed
wants to merge 3 commits into from
Closed

Maximum volumetric flow rate, with fixes #1828

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 12, 2023

Description

This PR adds functionality for setting a maximum volumetric flow rate, which prevents hitting the limit at which a certain hotend can melt material.

This PR attempts to fix the compilation errors in #1814

/home/runner/work/CuraEngine/CuraEngine/src/LayerPlan.cpp:2129:23: error: assignment of read-only variable ‘extrude_speed’
 2129 |         extrude_speed *= max_mm3_per_sec / mm3_per_sec;

It contains the commit from #1814 and therefore all necessary changes to CuraEngine.

It goes with #14452 on Cura, which adds the required settings to the frontend.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Compiled flawless.

The preview clearly shows that the flow and speed get limited if the maximum flow rate is reached:

With maximum set to 0.0mm³/s (disabled):

Screenshot_20230212_154216

With maximum set to 5mm³/s:

Screenshot_20230212_154244

Test Configuration:

  • Operating System:
    Arch 6.1.10 Wayland/KDE

Checklist:

  • My code follows the style guidelines of this project as described in UltiMaker Meta
  • I have read the Contribution guide
  • I have commented my code, particularly in hard-to-understand areas
  • I have uploaded any files required to test this change

@mjc-506
Copy link

mjc-506 commented Feb 19, 2023

Thanks for 'updating' the PR and sorry for the very slow response! There does appear to have been a change to const variables at some point between submitting my original PR and the tests being run... I'll consider that 'lucky' haha

@ghost ghost closed this by deleting the head repository Mar 15, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants