Bug Fix: reworked line polygon crossings so that combing copes with complex boundaries #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x comb boundaries. Before, if a travel crossed multiple polygons it could fail to detect all of the crossings and the resulting comb path could cross regions that it should not.
…t crossings, duh!
|
Devs. CURA-6112 |
|
I'll like to second that PR, because I ran into the same issue on a 3Dbenchy (!?!). |
…on-crossings # Conflicts: # src/pathPlanning/LinePolygonsCrossings.cpp
Ghostkeeper
approved these changes
Oct 25, 2019
Good that I saw you post this, I had this one pegged as the next one to-do, but couldn't get to it yesterday. Almost also started a review :-) |
|
Well it's got a Jira ticket so Jira would've resolved the conflict anyway :) |
|
Took a while, but indeed I found some cases where it improved combing. It doesn't seem to have any noticeable performance impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original line polygon crossings implementation did not cope with complex combing regions well because it assumed that each polygon in the combing boundary could only have a single crossing pair. This is not true for complex combing regions that have multiple holes.
Before this PR...
With this PR...
This PR fixes Ultimaker/Cura#5116.
Note that the problem is not only with no-skin combing, it can occur with any combing where the combing region is sufficiently complex.