[CURA-11485] Fix: z-offset as a property of gcode paths #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'just get it working' version. part of CURA-11265
…onal_layer_height
part of CURA-11485 (also reference CURA-11265 since that's what the original fix was made under).
Apparently it got confused last time. Solve it in a more sensible way (hopefully). done as part of CURA-11485 (also reference CURA-11265, since the original fix that I needed this for was done under that ticket but never pushed because otherwise we'd have to update the API version nr).
This reverts commit de26739.
done as part of CURA-11485 (also reference CURA-11265)
wawanbreton
requested changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This z-offset was added as a property in parallel to the plugins, so we missed it, then couldn't update due to the 5.6 release being feature-frozen. Add it now that we still can for the current release.