Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Dagoma material specifications #5

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

ubitux
Copy link
Contributor

@ubitux ubitux commented Jan 29, 2017

This is extracted (automatically, with a script) from the
resources/XML/xml_config.xml file installed by the Windows install
CuraByDagoma_E200_1480427910_d0965d25707767ef87c626dfbaaab4c9.zip
(dist.dagoma.fr).

Dagoma is the main distributor of these material brands.

Note: the filament_flow setting is NOT imported as there is no such
thing in the current Cura version in materials

Note: the color_code are not set

Note: the Cura UI is not intuitive with "Generic" types, you get menus
such as "brand → PLA → PLA", which is redundant.

Note: XML for materials, JSON for printers and INI for qualities looks
inconsistent

Note: actual printing untested

This is extracted (automatically, with a script) from the
resources/XML/xml_config.xml file installed by the Windows install
CuraByDagoma_E200_1480427910_d0965d25707767ef87c626dfbaaab4c9.zip
(dist.dagoma.fr).

Dagoma is the main distributor of these material brands.

Note: the filament_flow setting is *NOT* imported as there is no such
thing in the current Cura version in materials

Note: the color_code are not set

Note: the Cura UI is not intuitive with "Generic" types, you get menus
such as "brand → PLA → PLA", which is redundant.

Note: XML for materials, JSON for printers and INI for qualities looks
inconsistent

Note: actual printing untested
@Ghostkeeper
Copy link
Contributor

Ghostkeeper commented Jan 31, 2017

Comments on your notes:

  • Indeed, filament flow can't be set in there. That's something we'd like to change in the future. Nothing you could do about it.
  • About the colour code, that's too bad. But I imagine you wouldn't want to make definitions for all of the different colours everyone provides. We'd like to have that in the future some day.
  • The "Generic" types note is related to the colour codes. The materials in those menus are intended to be an actual specific product, not "PolyFlex-but-otherwise-generic" or something. Perhaps we'll change that eventually later.
  • Indeed, those three different formats is very inconsistent and we'd like to change that some day. It's a bit complicated because the materials is the worst format of them all but that one is shared with the firmware of the Ultimaker 3 so it requires some coordination.

@Ghostkeeper
Copy link
Contributor

Less the notes, this looks to be working fine. Reviewed and tested. I have permission from all teams involved to add new materials.

@fieldOfView
Copy link
Contributor

I could be wrong (because I don't have access to the specification), but aren't version, guid and color_code required in the specification?

@Ghostkeeper
Copy link
Contributor

We recently ran into issues because the version number is missing from these files. Colour code seems to be optional. GUID I don't know. In any case, I didn't review these thoroughly enough back then, but we'll make modifications as necessary.

@fieldOfView
Copy link
Contributor

Cura does throw a number of warnings when displaying the materials page. But I don't know if that's the material's fault or Cura's. Is the fmdmaterial spec available somewhere?

@ubitux
Copy link
Contributor Author

ubitux commented Apr 13, 2017

Note: in their current state, these materials do not work very well due to Ultimaker/Cura#1496
Flexible and Wood need to have their type changed as a workaround.

ckielstra pushed a commit that referenced this pull request Feb 22, 2019
* Add initial Tough PLA files. Profiles are copied from normal PLA

Other information is still copied from normal PLA, to be revised later

EM-2076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants