Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups #83

Merged
merged 8 commits into from
May 29, 2024
Merged

Minor cleanups #83

merged 8 commits into from
May 29, 2024

Conversation

d-tatianin
Copy link
Member

No description provided.

@d-tatianin
uacpi: remove excess logging for _STA/_INI execution
eb6b0c3 
There's no reason to trace aborts locally since it's already traced by
the interpreter anyway.

Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
@d-tatianin
opregion: actually log errors in trace_region_error
303b94d 
Do what it says on the tin.

Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
@d-tatianin
interpreter: make break-outside-of-while an error log level
065b76b 
This leads to an abort so it's a hard error.

Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
@d-tatianin
interpreter: EXEC_OP_WARN -> ERR & a separate WARN helper
d902e05 
Most of these were tracing errors, so no reason to log them as warnings.

There was exactly one place that actually wanted a warning, so we keep
it as such.

Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
@d-tatianin
utilities: simplify uacpi_eval_sta by using uacpi_eval_integer
0a1d261 
Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
@d-tatianin
interpreter: make invalid-number-of-arguments an error log
f48cd1a 
The call is aborted in this case, so this is an error.

Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
@d-tatianin
interpreter: make uacpi_osi typecheck log errors
6a87647 
This also makes it return the correct status code for this case.

Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
@d-tatianin
utilities: log errors in uacpi_get_pci_routing_table
b934b23 
These lead to method abort, therefore they're errors.

Signed-off-by: Daniil Tatianin <99danilt@gmail.com>
@d-tatianin d-tatianin merged commit bd4a2ac into master May 29, 2024
8 checks passed
@d-tatianin d-tatianin deleted the logging-cleanup branch May 29, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@d-tatianin