-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcting formats of dates for each language (CLDRv42) #723
Conversation
For each language, the dateformat is taken from CLDR v42 (2022-10-17)
Just wanted to say thanks for this change - I noticed that the format for English was not correct but never got around to open an issue... |
I'm a native Dutch speaker, and |
I'm pretty sure this is possible, but I wouldn't bother until people start making issues about "I don't understand YYYY-MM-DD date format". Pretty sure they can also just make their own modified language file for this. Anyway, thanks for this PR! I've changed the date format in my local builds ages ago, just never really got around to submit it. Mine would have only changed the English one, too, so this is a much more comprehensive PR. Expect it to get merged before the end of the week. |
@lesderid as stated in the commit, this is based on the latest data from CLDR v42 For Dutch (Dutch Netherlands) the format is But CLDR does say it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this improvement! I checked a bunch of them manually and asked friends from different countries to comment on the format choices, and they seem to fit well enough, at least much better than the previous default.
Kinda annoying that countries don't all just switch to the ISO standard for whatever reason 😅
For each language, the dateformat is updated and corrected for each language, taken from CLDR v42 (2022-10-17)
Most languages had the format MM.DD.YYYY which isn't appropriate for most language. Each language has been changed to reflect the exact format provided by CLDR, the standard used by Microsoft, Android, Apple to provide dates on the system. Czech, French, Luxembourgish and Portuguese were already using DMY, but has been modified to match CDLR instead, for consistency.
The file language.new has also been updated and changed from MM.DD.YYYY to DD.MM.YYYY to reflect the most common format globally. English, since it's used globally with different formats, has been changed from MM.DD.YYYY to YYYY-MM-DD, a neutral ISO 8601-format, unless specific versions of English can be added, such as UK and US English.
Changes: