-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.45.1 support for /ununifi/cdp and /unifi/cdp/create #229
Conversation
After some more revision of the other component to make build pass, I tried to create a CDP with type ubtc-jpy-3-2. But, the same issue that we (me and @YasunoriMATSUOKA ) had occurred. |
@taikiFurusyo Well, I concern that the reason CI is failing is because the changes to package-lock.json have not been committed. Please execute npm i again and commit the changes to package-lock.json, just to be sure. |
Oh, thanks for the precise advise. |
ff3e998 |
@Senna46 |
@YasunoriMATSUOKA ChangesThe display of CDP parameters is changed.
|
@Senna46 |
Untested. is it ok to check with ununifi-8-private-test? |
Yes. Plz check with ununifi-8-private-test. |
@YasunoriMATSUOKA CC: @taikiFurusyo On the other hand, there is a problem that it does not appear in |
@Senna46 |
@YasunoriMATSUOKA |
@Senna46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem was the change of the type that is created by ununifi-client automatically.
Specifically, IParams became to have two array objects which are collateral_params and debt_params. But, the code wasn't applied to these change.
So, we made principalDebtParam variable to compromise with pages/create/create component com in project/telescope-extension/src/app/utils/function.ts.