Skip to content

Commit 8265e23

Browse files
committed
Added requested changes v2
1 parent 3853466 commit 8265e23

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

.github/pull_request_template.md

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ Please include a summary of the change and which issue is fixed. List any depend
1010

1111
## Fixes #(issue_no)
1212

13+
<!-- Replace `issue_no` with the issue number which is fixed in this PR -->
14+
1315
## Type of change
1416

1517
_Please delete options that are not relevant._
@@ -28,10 +30,13 @@ _Please delete options that are not relevant._
2830
- [ ] I have created a helpful and easy to understand `README.md`
2931
- [ ] My documentation follows [`Template for README.md`](https://github.com/avinashkranjan/Amazing-Python-Scripts/blob/master/Template%20for%20README.md)
3032
- [ ] I have added the project meta data in the PR template.
33+
- [ ] I have created the ``requirements.txt`` file if needed.
3134

3235
## Project Metadata
3336

34-
`` If there is nothing to fill with, then type: none ``
37+
`` If there is no-file/nothing to fill the below fields with, then type: none ``
38+
39+
`` Example: `` If no requirements.txt needed/present then type in ``Requirments`` none => ``Requirments: none``
3540

3641
Category:
3742
- [ ] Calculators
@@ -50,16 +55,16 @@ Category:
5055
- [ ] Fun
5156
- [ ] Others
5257

53-
Title: \<write scrip title here\>
58+
Title: \<write script title here\>
5459

5560
Folder: \<type the folder name that contains your script\>
5661

57-
Requirments: \<type the name of text file containing the required to install python packages\>
62+
Requirments: \<type the name of text file containing the required to install python packages, type None if no file required\>
5863

59-
Script: \<Enter the name of the ``.py`` file\>
64+
Script: \<Enter the name of the ``.py`` file (The main entry point of the program)\>
6065

6166
Arguments: \<enter any arguments that the script needs but `-` separeted like: h-c-m\>
6267

63-
Contributor: \<Enter your Github handle/username\>
68+
Contributor: \<Enter your Github handle/username without url\>
6469

65-
Description: \<Enter a one line description that describes your script\>
70+
Description: \<Enter a one line description that describes your script. Also, explain the arguments usage here\>

.github/scripts/Update_Database.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def extract_from_pr_body(pr_body, pa_token):
5959
for element in pr_body:
6060
pr_body[pr_body.index(element)] = element.rstrip("\r")
6161

62-
# A special case for contributors in gh-pages branch
62+
# A special case for contributors in gh-pages branch and other dependency PRs
6363
try:
6464
pr_body = pr_body[pr_body.index("## Project Metadata"):]
6565
except:

0 commit comments

Comments
 (0)