Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS - rework setup.py #6

Closed
glemaitre opened this issue Apr 23, 2018 · 5 comments
Closed

JOSS - rework setup.py #6

glemaitre opened this issue Apr 23, 2018 · 5 comments

Comments

@glemaitre
Copy link

The setup.py is not really nice. I would advice to use a template as here

@glemaitre
Copy link
Author

You should restrict the install to python 3 only since this is not python 2 compatible:
https://packaging.python.org/tutorials/distributing-packages/#python-requires

@glemaitre
Copy link
Author

Improve the setup as well such that there information in the PyPi webpage.

@lfasnacht
Copy link
Member

I improved setup.py. I didn't follow the logic in the shablona project, as I'm not fond of it. I used some inspiration from the pypa sample setup.py.

Is this file "nice enough"? Or do you see additional improvements?

@glemaitre
Copy link
Author

It seems almost good. Could you take care about the PEP8.
Also it has to be check, for the long description I don't remember if you can give markdown or it needs to be rst to render properly on PyPi. But this point does not need to be addressed, you will see at the release time.

@lfasnacht
Copy link
Member

It should work.

PEP8 is in my to-do list, but I'll do the code styling all at once, I'm working on the coverage at present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants