Add Mean Sea Level Pressure Reduction #1700
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, this looks pretty good. Is vapor pressure what's usually used in the NWS correction? |
|
Yes, that is my understanding. I am attaching the NWS manual since it is hard to find online. SLP reduction is in chapter 7. |
| Fitted from table of empirically derived values found in NWS Manual of Barometry. | ||
| """ | ||
| const = np.array([5.04969979e-6, 1.30236277, 1.96926239e-1]) | ||
| return (const[0] * (height.to('meter').m**const[1]) + const[2]) * units('degF / hPa') |
There was a problem hiding this comment.
I think units on the correction should be delta_degF / hPa
Comment on lines
+1252
to
+1254
| mean_temp = temperature.to('kelvin') + \ | ||
| ((lapse_rate * geopotential_height) / 2.).to('kelvin') + \ | ||
| (vapor_pressure * humidity_correction(geopotential_height)).to('kelvin') |
There was a problem hiding this comment.
You shouldn't need to manually convert to Kelvin if you make the change above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Adds function for sea level pressure reduction from surface variables and altitude. I am marking this as a draft as I am expecting the need for some discussion regarding implementation details. The function implements the NWS standard reduction with some minor changes, most notably using a curve fit rather than look-up table. Discussion regarding the appropriate moisture variable to expect may also be desired. Some additional testing on real data is still needed, my initial testing with model output looked pretty good, I want to compare more directly with other implementations and use it on some surface station data.
Checklist