Fix GEMPAK date parsing #2231
Merged
Fix GEMPAK date parsing #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Unidata#2229 The code implicitly assumed the date integer from GEMPAK has six characters, but an integer like 000102 (for January 2, 2000) will be reduced to 102 during the string conversion. Here, a formatted string is used to make sure any leading zeroes are kept.
|
I guess I didn't set up the test properly for Github, but I'm not sure what I did wrong. |
dopplershift
approved these changes
Nov 30, 2021
dopplershift
added
Area: IO
|
Thanks for contributing the fix! This looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Uses a formatted string to make sure integers with leading zeroes retain those leading zeroes.
Checklist