Unit support for interpolation functions #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a PyCharm warning and is more normal anyway.
Hoist validation and selection of interpolation method out of the loop. Also make use of np.full() and compress down some steps a bit.
dopplershift
added
Area: Calc
dopplershift
changed the title
dopplershift
changed the title
dcamron
reviewed
Jan 21, 2022
dcamron
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Add support for units throughout the inverse distance weighting and natural neighbor interpolation code. Also ensure that
interpolate_to_gridreturns values with the same units as input for all methods.Checklist
inverse_distance_to_points#2243