Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coord criteria regex so that X prefixes or _ infixes don't break it #2347

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

jthielen
Copy link
Collaborator

Description Of Changes

Over the course of working on xarray-contrib/xwrf#14 and recieving feedback on it, bugs arose in some edge cases of the regex coordinate criteria, particularly, XTIME got interpretted as an x axis coordinate (which is very much not right). To resolve this, I tightened the criteria with start and end matching, and then filled in what I'd otherwise expect to be allowed in between. WRF/xwrf-motivated test dimension names have also been added.

Checklist

  • Closes
  • Tests added
  • Fully documented

@jthielen jthielen added Type: Bug Something is not working like it should Area: Xarray Pertains to xarray integration labels Feb 15, 2022
@jthielen jthielen added this to the 1.3.0 milestone Feb 15, 2022
@jthielen jthielen requested a review from a team as a code owner February 15, 2022 22:43
@jthielen jthielen requested review from dopplershift and removed request for a team February 15, 2022 22:43
@jthielen
Copy link
Collaborator Author

Codespell is failing on pres (instead of press), which seems to be causing the required linting CI to fail. What approach should I use to override codespell for this?

@dcamron
Copy link
Member

dcamron commented Feb 15, 2022

That line was previous excluded via the .codespellignore file, so you should be able to just update that line to match your change (must be exact!).

dopplershift
dopplershift previously approved these changes Feb 16, 2022
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo fixing for codespell (as @dcamron correctly stated how to suppress).

@jthielen
Copy link
Collaborator Author

.codespellignore has been updated as suggested, and it looks like lint CI is now passing!

@dopplershift dopplershift merged commit c68cc7d into Unidata:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Xarray Pertains to xarray integration Type: Bug Something is not working like it should
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants