Remove "united" as meaning "having units" #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't say I'm a huge fan of the introduction of "un-unit-ed" throughout. I think "has units", "unitless", or even just letting "quantities" imply units throughout as appropriate seems cleaner to me. |
|
In light of @dcamron comment and reviewing the Pint nomenclature, I think using quantity to signify an array with units is the way to go. Then anything without units could just be referred to as an array. This would also have the benefit of aligning with our use of xarray and |
|
Ok, I rewrote this to just avoid "unit[-]?ed" altogether. Lemme know what y'all think. |
dopplershift
changed the title
dcamron
requested changes
Jun 1, 2022
Instead use "quantity" as the general concept, and otherwise clarify using the phrase "with units" or otherwise clarifying as needed.
dcamron
approved these changes
Jun 2, 2022
dopplershift
added
the
backport
|
🏁 Successfully backported as #2566. 🏁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
"united" doesn't mean what we want it to in these contexts. Let's go with "unit-ed" at least. I am open to changing to things like "quantity with units" or...?
Checklist
[ ] Closes #xxxx[ ] Tests added[ ] Fully documented